qemu_domain, qemu_process: maxCpus check to non-x86 guests

[libvirt] [PATCH v2 0/5] qemu_domain, qemu_process: maxCpus check to non-x86 guests

Posted by Daniel Henrique Barboza 5 years, 5 months ago

v2:
- original patch was split in 3 patches as John Ferlan requested;
- patches 4 and 5 are cleanups;
- first patch link:
https://www.redhat.com/archives/libvir-list/2018-October/msg00251.html



Daniel Henrique Barboza (5):
  qemu_process.c: adding maxCpus value to error message
  qemu_process.c: make qemuValidateCpuCount public
  qemu_domain.c: moving maxCpu validation to qemuDomainDefValidate
  qemu_process.c: moving qemuValidateCpuCount to qemu_domain.c
  qemu_process.c: removing qemuProcessStartValidateXML

 src/qemu/qemu_domain.c  | 27 +++++++++++++++++++
 src/qemu/qemu_process.c | 57 ++++-------------------------------------
 2 files changed, 32 insertions(+), 52 deletions(-)

-- 
2.19.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 0/5] qemu_domain, qemu_process: maxCpus check to non-x86 guests

Posted by John Ferlan 5 years, 5 months ago


On 11/14/18 2:52 PM, Daniel Henrique Barboza wrote:
> v2:
> - original patch was split in 3 patches as John Ferlan requested;
> - patches 4 and 5 are cleanups;
> - first patch link:
> https://www.redhat.com/archives/libvir-list/2018-October/msg00251.html
> 
> 
> 
> Daniel Henrique Barboza (5):
>   qemu_process.c: adding maxCpus value to error message
>   qemu_process.c: make qemuValidateCpuCount public
>   qemu_domain.c: moving maxCpu validation to qemuDomainDefValidate
>   qemu_process.c: moving qemuValidateCpuCount to qemu_domain.c
>   qemu_process.c: removing qemuProcessStartValidateXML
> 
>  src/qemu/qemu_domain.c  | 27 +++++++++++++++++++
>  src/qemu/qemu_process.c | 57 ++++-------------------------------------
>  2 files changed, 32 insertions(+), 52 deletions(-)
> 

Reviewed-by: John Ferlan <jferlan@redhat.com>
(series) and pushed.

Congrats on your first libvirt patches.

John

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 0/5] qemu_domain, qemu_process: maxCpus check to non-x86 guests

Posted by Daniel Henrique Barboza 5 years, 5 months ago


On 11/15/18 7:40 PM, John Ferlan wrote:
>
> On 11/14/18 2:52 PM, Daniel Henrique Barboza wrote:
>> v2:
>> - original patch was split in 3 patches as John Ferlan requested;
>> - patches 4 and 5 are cleanups;
>> - first patch link:
>> https://www.redhat.com/archives/libvir-list/2018-October/msg00251.html
>>
>>
>>
>> Daniel Henrique Barboza (5):
>>    qemu_process.c: adding maxCpus value to error message
>>    qemu_process.c: make qemuValidateCpuCount public
>>    qemu_domain.c: moving maxCpu validation to qemuDomainDefValidate
>>    qemu_process.c: moving qemuValidateCpuCount to qemu_domain.c
>>    qemu_process.c: removing qemuProcessStartValidateXML
>>
>>   src/qemu/qemu_domain.c  | 27 +++++++++++++++++++
>>   src/qemu/qemu_process.c | 57 ++++-------------------------------------
>>   2 files changed, 32 insertions(+), 52 deletions(-)
>>
> Reviewed-by: John Ferlan <jferlan@redhat.com>
> (series) and pushed.
>
> Congrats on your first libvirt patches.


Thanks! Looking forward for more!



Daniel

>
> John

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list