[libvirt] [PATCH] news: Add entry for soft reset support in Xen

Jim Fehlig posted 1 patch 5 years, 5 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20181108155259.26920-1-jfehlig@suse.com
Test syntax-check passed
docs/news.xml | 11 +++++++++++
1 file changed, 11 insertions(+)
[libvirt] [PATCH] news: Add entry for soft reset support in Xen
Posted by Jim Fehlig 5 years, 5 months ago
Signed-off-by: Jim Fehlig <jfehlig@suse.com>
---

I'm torn on whether this is a new feature, improvement, or even
simply a bug fix...

 docs/news.xml | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/docs/news.xml b/docs/news.xml
index 9d98c34df2..e1d10cf7f1 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -35,6 +35,17 @@
 <libvirt>
   <release version="v4.10.0" date="unreleased">
     <section title="New features">
+      <change>
+        <summary>
+          Xen: Add support for soft reset shutdown event
+        </summary>
+        <description>
+          The pvops Linux kernel uses soft reset to handle the crash
+          machine operation. The libxl driver now supports the soft
+          reset shutdown event, allowing proper crash handling of
+          pvops-based HVM domains.
+        </description>
+      </change>
     </section>
     <section title="Improvements">
     </section>
-- 
2.18.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] news: Add entry for soft reset support in Xen
Posted by Andrea Bolognani 5 years, 5 months ago
On Thu, 2018-11-08 at 08:52 -0700, Jim Fehlig wrote:
> Signed-off-by: Jim Fehlig <jfehlig@suse.com>
> ---
> 
> I'm torn on whether this is a new feature, improvement, or even
> simply a bug fix...

The categories are quite fuzzy, but that also means that getting it
100% right is not that important :)

Personally I'd lean towards bug fix, since it's something that users
might reasonably have expected to work even before now; regardless of
which specific bucket you decide to throw this in,

  Reviewed-by: Andrea Bolognani <abologna@redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] news: Add entry for soft reset support in Xen
Posted by Jim Fehlig 5 years, 5 months ago
On 11/8/18 10:27 AM, Andrea Bolognani wrote:
> On Thu, 2018-11-08 at 08:52 -0700, Jim Fehlig wrote:
>> Signed-off-by: Jim Fehlig <jfehlig@suse.com>
>> ---
>>
>> I'm torn on whether this is a new feature, improvement, or even
>> simply a bug fix...
> 
> The categories are quite fuzzy, but that also means that getting it
> 100% right is not that important :)
> 
> Personally I'd lean towards bug fix, since it's something that users
> might reasonably have expected to work even before now; 

Thanks!. I moved it to the bug fixes section, tweaked the summary just a bit to 
read more like a bug fix, and pushed.

Regards,
Jim

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list