On Thu, Oct 25, 2018 at 09:44:01PM +0100, Daniel P. Berrangé wrote:
> On Sat, Oct 20, 2018 at 05:19:47PM +0300, Roman Bolshakov wrote:
> > Signed-off-by: Roman Bolshakov <r.bolshakov@yadro.com>
> > ---
> > src/qemu/qemu_capabilities.c | 1 +
> > src/qemu/qemu_capabilities.h | 1 +
> > 2 files changed, 2 insertions(+)
> >
> > diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
> > index e228f52ec0..65cf5b5c03 100644
> > --- a/src/qemu/qemu_capabilities.c
> > +++ b/src/qemu/qemu_capabilities.c
> > @@ -508,6 +508,7 @@ VIR_ENUM_IMPL(virQEMUCaps, QEMU_CAPS_LAST,
> > /* 315 */
> > "vfio-pci.display",
> > "blockdev",
> > + "hvf",
> > );
> >
> >
> > diff --git a/src/qemu/qemu_capabilities.h b/src/qemu/qemu_capabilities.h
> > index 934620ed31..e61f1e78a9 100644
> > --- a/src/qemu/qemu_capabilities.h
> > +++ b/src/qemu/qemu_capabilities.h
> > @@ -492,6 +492,7 @@ typedef enum { /* virQEMUCapsFlags grouping marker for syntax-check */
> > /* 315 */
> > QEMU_CAPS_VFIO_PCI_DISPLAY, /* -device vfio-pci.display */
> > QEMU_CAPS_BLOCKDEV, /* -blockdev and blockdev-add are supported */
> > + QEMU_CAPS_HVF, /* Whether Hypervisor.framework is available */
> >
> > QEMU_CAPS_LAST /* this must always be the last item */
> > } virQEMUCapsFlags;
>
> I expect this addition would have broken the 'make check' tests
> for the capabilities, so they likely need an update.
Hi Daniel,
Indeed, that's true. It broke all but 4 capabilities tests on PATCH 11
(https://www.redhat.com/archives/libvir-list/2018-October/msg01098.html)
including the ones I didn't expect, like tests for s390x. I wonder what
could be the reason?
I have looked at the recent additions of capabilities. Most of them just
add a flag for related platform and that's it. That doesn't work for me
though. May be that's because I should add CPU definitions for hvf
domain type? Still, that doesn't explain how hvf cpu appeared in actual
output of s390x capabilities test:
<hostCPU type='hvf' model='z14-base' migratability='no'>
May be a cross-product of all domain types and all
CPUs is checked.
I've attached test log file.
The code can be checked out of hvf-domain branch in the repo:
https://github.com/roolebo/libvirt.git
--
Best regards,
Roman
�7zXZ �ִF ! t/���O(�] *F���'x %v��[z��; �:�pa���r�e#��fu���������ż���JD_tM��C��
��+1[=uU[j�m �� g�RC�Ȍ�SB�F�:�z�+K�`q+���B��ޭH�s�ğ�E��P��CX��(P<���.�@2C�~,��>L�g\����ؔC��L߀��}�6���"�Ph8�����F<��tIҕ$����e�s�ӫ
����ee �0,�z��@��Q���ى�m�W���8��5U�Dέ�2`���q���@L��Q�d�X���U1˃Ҁ�O��q�Pq��H�ү6*�"�IJ��Un���C� ��Ɲ�D�8Dzhz������wCx����*�!ܐ�@L�!"��{a�A�̴�[�(S%]ljǞ��� �彷��DU���S���(�UlX�D ��t,�s�7C�./�� ����XUsTGZ4w�v�T$��v��FSY�����D�B/��eIF���0���AL�`I�q\1{��a�>S��-�XE�b�|�����lV�N|�04��$B��`'9�^K�@2M�Rt��7��[i�C���E��\� N���H�S������Q�� ��k�9�G��l�E��2��ԇ��4Q&�DrlB��.�ɢ����S���EK����,SQt���pݠ�Q��R&2�\�� Pz�GF��M�G�!�� �Ŗ���R]��)�k<�X~*��8�r�ZŹ/+���^�,
��{�6�idP�3u��H��Z$6��6���Q�[�C�0~���x��t����_J=�pS�ԕ|:9W���::�&���ҏ 함��}R9�� ?�K}�*�0k@��/cE����V�uL�ε�y�KD�/^�o^�������sq���-S����v���q�;���#ʱ��ϫ�<eN����/�Ƅ�����Ճ�$�_��B� @X¥Tw�A+�W���RM:��Ch!��i@)1`��E7}R�`���M�����=n6��F�m[/�:�͈�
at����5��מ��kR[e�?Em� 2��*�(%��H u�.��g��W~m!���Y� �tOb�'�����Ӛd��AR�s}�İ&��;�h��`C�C�[�'�z�㮈"�69����l����E\�����g�o�!�Yg�q5n���h2���
�D/�o���X>W�+��p��ĊBטe{f��Smg��V��Lbg
u�Nu^U��)8��i�G&-��3��،�jj��ގ����lY_�X��wt����YV�<m��¤B2�
���.h�Y� ����E�H N}��^�q�HN��9X�_���K��z`�۸������Ĝ���i)1C�Q��=�%S��k.��&�@��R++����պ� ��/%�0�e���/��%=�l�BTe(�YҒ����@�&��Sjض��X��۷ŵm�CI�(V�*�.����Gl�6i�5
�>��(lz_�C7/$�,IP^�]���p��"�O�p Ƹ��N���� �m���6!Xpط&f뮫�0�r�32��pk���e#��O ��5�"����qe��3�Fr�s���i�`��r��k���pZ?�Nz%;;[!0a�;�oV����)0���8����:�k��A�OY���*N��j��E��Q��Y���WI
yC./rN+���9������ga�
��"���뛂=}����2쌂�v���,����.�@�{0 pɡ��+��o����y�8/��}w?({z�KحF�gy:�M��=���Fܹ��Q\.2ɬ���`8l����Wz�s�>�
���/ȶ�U~��J�4�h�
������3��Q?,2��+=�"�WH��/�vP��L �38O9��Q�M����k0��HL���:��Jh��G�Uڟ��cF��06�,.�1w/�EW��rr*����.�*�k�l�����|�p����&�ɦ9U�H]D�xv������m����f:���:���"8ޘd��<����tF���+���L��L��a��s4�������+�c~u�R�.�1��WR�w��Y�b�>��Ƌ��:$�'��.\��i_����զ�NfpbPh�[�CRb��,ˀ�A `��V��60�EU><m���j'�M����ޫ�ڋ�c*K��2�8(�F0���Y�ޔ�A[5\'J�ȱH_(�Y���C[���;*��DÓ���F4{~L8~g'O�XB.
���(ϟ���0Edٙn�b�'U*C[.��PՆz��C��#ﲂ��v$�Ľ�mwZB���Ȫاy|�n���3B3T�p%�8�Z�����w�t��R�h�ۆ7��$h���g ��110���J~
9m���R��ou�z����&�p�]�:�:MlZ�n��,�Ǔ퇯S�|�"����4��i8�bYQ�K�����bq �᱄'�ʑ��s�*���zv�� ]r '"%�F8u�,P�=*�Qb%��!#�Ua;M�/�7��9��=JriQ���ڰ�q� �*Pgu�RB�Q�*j��t��M;�Z��L�)i��>�� �W�݄>����!(�8��Pw����r� Qi��=��JuM�3Zp�8��� ��p�U�p�����G\�t9�?���$��Y�~^�����X�(ۤ-qVR<6n�n���BM~/IG����a��S�d���6|�dV���OE�7�M2)h��w*�0�Sv�,8Kv�F; ��K���cM"��t�jdw%r��UO�i�\�WC��l�.��[�\?��'A�fW��[�W��:F��'� ��[*���sN�^}�z��*N�ϲ}���y��{{B�W�;�#���g�j�
�#2��T���ZV����'�
ٝ`<�H��nm�;c4F���dAV_�bRq�����R�='0��i�����U�7�F���E�+�n��F@pM�E{�_v\�A
iV.��<�$��U��L.}'����]��ɻ�Q&��U�;�dr���a�s;�-1DamJ�n��"G���t9�6��T��`�F�x���,�';%��`�g!�n��l��Z���jJ{H=�CB)�����7ud�� ހ�Z�����yv�� �'�"�Ų�L�ώ�(��C�!']t����cF�3"�e�w���Gh)Ƨ�~`.�0:OY@N#N��D�@�ds�����_>/�R�b,�x��_��A�I����av>��#�1s��+�`����*�!��_[�Wz"�JC�.W��Ji�gJ�+ �xQ������7϶,��=�̽%�Ķx�E�K|��0�a��m�߄u��شnmXH}��^>�]�J�+]lSP���H��5Ĕ�ǵ�
��*3�~o��d�<!�1�e�<&1����xh�.m��Q�$������դLN�ܯ��n���(3�2���;��k�z�nb/_�gv&aI�˟���6�C|��{�_
�^V�9�����X#8�ɣ�k�⺝\0Y]�<��9�NA ]!x����-��u���yG�z��s��VKOꚽ@���p�K��=��Xj���I�A v;9�R�^�'����eD^0�F�#��=�<}n�AKC����N����X'a���o=6̏�9@��
a��A`I�8N���/��Ʒ���*��d��䮊�;�V8ACw�e�1�]���G&�Z�0q�5U�R��ߥmJ(��2�&>P���a�ˬ�Ƶ��es�jL�9#_�}k+"����iZ��Z:>�X�ת��8����:��P��oU3ɔ�}%�� ��Ycõ�%=���u�<,�̊�݊��jP� ^�"�P5�d���sB,հ���$!|��A��/���-��%�
1��%�7��_��k;�tC��c�[����[��tzV�2ձE���|���~'w�~j�J��3/[e+.�8�d����m���h6$����9��� ���]�J�01]�+�Ȅ�jMF#����(|-�p)�mf�\#�'^�r�DG�!�ƹ�e�y�G{�@��5� ] (����.V#(T�D�m��wcv�53�/��v�Crc\�y�Jh�,/˯���Uu�v̖��!���'
[BϾ�I���3,��n\Y+��\�=��c�sNjk��}A�h���m&a��QP'��nE�� Z��� �^�S-*��24'