[v1] qemu: fix device name passed to error report

[libvirt] [PATCH] qemu: fix device name passed to error report

Daniel P. Berrangé posted 1 patch 5 years, 6 months ago

Diff against v1
Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20181019163520.9464-1-berrange@redhat.com

Test syntax-check passed

src/qemu/qemu_hotplug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[libvirt] [PATCH] qemu: fix device name passed to error report

Posted by Daniel P. Berrangé 5 years, 6 months ago

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 src/qemu/qemu_hotplug.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
index 0a63741b9e..12bef16fd6 100644
--- a/src/qemu/qemu_hotplug.c
+++ b/src/qemu/qemu_hotplug.c
@@ -5814,7 +5814,7 @@ qemuDomainDetachNetDevice(virQEMUDriverPtr driver,
     if (qemuIsMultiFunctionDevice(vm->def, &detach->info)) {
         virReportError(VIR_ERR_OPERATION_FAILED,
                        _("cannot hot unplug multifunction PCI device: %s"),
-                       dev->data.disk->dst);
+                       net->ifname);
         goto cleanup;
     }
 
-- 
2.17.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] qemu: fix device name passed to error report

Posted by John Ferlan 5 years, 6 months ago


On 10/19/18 12:35 PM, Daniel P. Berrangé wrote:
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  src/qemu/qemu_hotplug.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Trivial ;-), but implemented that way, see commit cb6ea85b7

So, extra credit for fixing qemuDomainDetachControllerDevice too (which
probably could follow qemuDomainDetachHostPCIDevice).

Reviewed-by: John Ferlan <jferlan@redhat.com>

John

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list