qemu: remove unreferenced variable

[libvirt] [PATCH] qemu: remove unreferenced variable

Bjoern Walk posted 1 patch 5 years, 6 months ago

Download mbox

Test syntax-check passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20181018080804.230644-1-bwalk@linux.ibm.com

src/qemu/qemu_process.c | 2 --
1 file changed, 2 deletions(-)

Expand all Fold all

[libvirt] [PATCH] qemu: remove unreferenced variable

Posted by Bjoern Walk 5 years, 6 months ago

The QEMU config in @cfg is not actually referenced in qemuProcessInit,
let's remove it.

Signed-off-by: Bjoern Walk <bwalk@linux.ibm.com>
---
 src/qemu/qemu_process.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index e9c76188..3955eda1 100644
--- a/src/qemu/qemu_process.c
+++ b/src/qemu/qemu_process.c
@@ -5267,7 +5267,6 @@ qemuProcessInit(virQEMUDriverPtr driver,
                 bool migration,
                 unsigned int flags)
 {
-    virQEMUDriverConfigPtr cfg = virQEMUDriverGetConfig(driver);
     virCapsPtr caps = NULL;
     qemuDomainObjPrivatePtr priv = vm->privateData;
     int stopFlags;
@@ -5347,7 +5346,6 @@ qemuProcessInit(virQEMUDriverPtr driver,
 
  cleanup:
     virCPUDefFree(origCPU);
-    virObjectUnref(cfg);
     virObjectUnref(caps);
     return ret;
 
-- 
2.17.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] qemu: remove unreferenced variable

Posted by Erik Skultety 5 years, 6 months ago

On Thu, Oct 18, 2018 at 10:08:04AM +0200, Bjoern Walk wrote:
> The QEMU config in @cfg is not actually referenced in qemuProcessInit,
> let's remove it.
>
> Signed-off-by: Bjoern Walk <bwalk@linux.ibm.com>

Reviewed-by: Erik Skultety <eskultet@redhat.com>

I slightly reworded the commit message and pushed the patch.

Thanks,
Erik

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list