[libvirt] [ocaml PATCH 0/4] Misc build improvements

Pino Toscano posted 4 patches 5 years, 6 months ago
Failed in applying to current master (apply log)
.gitignore          |   2 +
aclocal.m4          | 170 ----------------------------------
config.h.in         |  61 -------------
configure.ac        |  26 +-----
libvirt/Makefile.in |  14 +--
m4/ocaml.m4         | 217 ++++++++++++++++++++++++++++++++++++++++++++
6 files changed, 232 insertions(+), 258 deletions(-)
delete mode 100644 aclocal.m4
delete mode 100644 config.h.in
create mode 100644 m4/ocaml.m4
[libvirt] [ocaml PATCH 0/4] Misc build improvements
Posted by Pino Toscano 5 years, 6 months ago
A round of few build system improvements:
- use the OCaml build macros from libguestfs
- remove generated stuff
- use pkg-config to find & use libvirt

Pino Toscano (4):
  build: move OCaml macros to a m4 subdir
  build: sync OCaml macros from libguestfs
  build: remove config.h.in
  build: use pkg-config to find libvirt

 .gitignore          |   2 +
 aclocal.m4          | 170 ----------------------------------
 config.h.in         |  61 -------------
 configure.ac        |  26 +-----
 libvirt/Makefile.in |  14 +--
 m4/ocaml.m4         | 217 ++++++++++++++++++++++++++++++++++++++++++++
 6 files changed, 232 insertions(+), 258 deletions(-)
 delete mode 100644 aclocal.m4
 delete mode 100644 config.h.in
 create mode 100644 m4/ocaml.m4

-- 
2.17.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [ocaml PATCH 0/4] Misc build improvements
Posted by Richard W.M. Jones 5 years, 6 months ago
On Mon, Oct 15, 2018 at 04:02:31PM +0200, Pino Toscano wrote:
> A round of few build system improvements:
> - use the OCaml build macros from libguestfs
> - remove generated stuff
> - use pkg-config to find & use libvirt
> 
> Pino Toscano (4):
>   build: move OCaml macros to a m4 subdir
>   build: sync OCaml macros from libguestfs
>   build: remove config.h.in
>   build: use pkg-config to find libvirt
> 
>  .gitignore          |   2 +
>  aclocal.m4          | 170 ----------------------------------
>  config.h.in         |  61 -------------
>  configure.ac        |  26 +-----
>  libvirt/Makefile.in |  14 +--
>  m4/ocaml.m4         | 217 ++++++++++++++++++++++++++++++++++++++++++++
>  6 files changed, 232 insertions(+), 258 deletions(-)
>  delete mode 100644 aclocal.m4
>  delete mode 100644 config.h.in
>  create mode 100644 m4/ocaml.m4

Looks fine, ACK series.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
Fedora Windows cross-compiler. Compile Windows programs, test, and
build Windows installers. Over 100 libraries supported.
http://fedoraproject.org/wiki/MinGW

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list