[libvirt] [PATCH v2 8/8] news: Cold(un)plug and hot(un)plug support for usb hub device

Han Han posted 8 patches 7 years, 3 months ago
[libvirt] [PATCH v2 8/8] news: Cold(un)plug and hot(un)plug support for usb hub device
Posted by Han Han 7 years, 3 months ago
Signed-off-by: Han Han <hhan@redhat.com>
---
 docs/news.xml | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/docs/news.xml b/docs/news.xml
index dc08c96352..0efad21758 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -35,6 +35,11 @@
 <libvirt>
   <release version="v4.9.0" date="unreleased">
     <section title="New features">
+      <change>
+        <summary>
+          qemu: Add support for cold(un)plugging and hot(un)plugging usb hub device
+        </summary>
+      </change>
     </section>
     <section title="Improvements">
     </section>
-- 
2.19.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v2 8/8] news: Cold(un)plug and hot(un)plug support for usb hub device
Posted by John Ferlan 7 years, 3 months ago

On 10/12/18 4:50 AM, Han Han wrote:
> Signed-off-by: Han Han <hhan@redhat.com>
> ---
>  docs/news.xml | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/docs/news.xml b/docs/news.xml
> index dc08c96352..0efad21758 100644
> --- a/docs/news.xml
> +++ b/docs/news.xml
> @@ -35,6 +35,11 @@
>  <libvirt>
>    <release version="v4.9.0" date="unreleased">
>      <section title="New features">
> +      <change>
> +        <summary>
> +          qemu: Add support for cold(un)plugging and hot(un)plugging usb hub device
> +        </summary>
> +      </change>

How about:

<summary>
  Add active and inactive device add or remove for QEMU USB Hub devices
</summary>
<description>
  Add the ability to attach or detach a USB Hub device either for
  active or inactive guests.
</description>

?

John

>      </section>
>      <section title="Improvements">
>      </section>
> 

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v2 8/8] news: Cold(un)plug and hot(un)plug support for usb hub device
Posted by Han Han 7 years, 3 months ago
On Tue, Nov 6, 2018 at 6:52 AM John Ferlan <jferlan@redhat.com> wrote:

>
>
> On 10/12/18 4:50 AM, Han Han wrote:
> > Signed-off-by: Han Han <hhan@redhat.com>
> > ---
> >  docs/news.xml | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/docs/news.xml b/docs/news.xml
> > index dc08c96352..0efad21758 100644
> > --- a/docs/news.xml
> > +++ b/docs/news.xml
> > @@ -35,6 +35,11 @@
> >  <libvirt>
> >    <release version="v4.9.0" date="unreleased">
> >      <section title="New features">
> > +      <change>
> > +        <summary>
> > +          qemu: Add support for cold(un)plugging and hot(un)plugging
> usb hub device
> > +        </summary>
> > +      </change>
>
> How about:
>
> <summary>
>   Add active and inactive device add or remove for QEMU USB Hub devices
> </summary>
> <description>
>   Add the ability to attach or detach a USB Hub device either for
>   active or inactive guests.
> </description>
>
Well. Your advice is nice. 'active' or 'inactive' is to describe the guests
not the devices.

>
> ?
>
> John
>
> >      </section>
> >      <section title="Improvements">
> >      </section>
> >
>


-- 
Best regards,
-----------------------------------
Han Han
Quality Engineer
Redhat.

Email: hhan@redhat.com
Phone: +861065339333
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list