Avoid numerous calls of virQEMUCapsCacheLookup

[libvirt] [PATCH 01/11] qemu: Use VIR_STEAL_PTR macro

Posted by Marc Hartmayer 7 years, 4 months ago

Signed-off-by: Marc Hartmayer <mhartmay@linux.ibm.com>
Reviewed-by: Bjoern Walk <bwalk@linux.ibm.com>
Reviewed-by: Boris Fiuczynski <fiuczy@linux.ibm.com>
Reviewed-by: Stefan Zimmermann <stzi@linux.ibm.com>
---
 src/qemu/qemu_domain.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index 2fd8a2a268cd..06aa1fac5d0b 100644
--- a/src/qemu/qemu_domain.c
+++ b/src/qemu/qemu_domain.c
@@ -2921,8 +2921,7 @@ qemuDomainObjPrivateXMLParse(xmlXPathContextPtr ctxt,
             }
         }
 
-        priv->qemuCaps = qemuCaps;
-        qemuCaps = NULL;
+        VIR_STEAL_PTR(priv->qemuCaps, qemuCaps);
     }
     VIR_FREE(nodes);
 
-- 
2.17.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 01/11] qemu: Use VIR_STEAL_PTR macro

Posted by John Ferlan 7 years, 4 months ago


On 9/20/18 1:44 PM, Marc Hartmayer wrote:
> Signed-off-by: Marc Hartmayer <mhartmay@linux.ibm.com>
> Reviewed-by: Bjoern Walk <bwalk@linux.ibm.com>
> Reviewed-by: Boris Fiuczynski <fiuczy@linux.ibm.com>
> Reviewed-by: Stefan Zimmermann <stzi@linux.ibm.com>
> ---
>  src/qemu/qemu_domain.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 

Reviewed-by: John Ferlan <jferlan@redhat.com>

Trivial, but I'll wait until freeze of off before pushing...

John

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list