[v2] Introduce VIR_AUTOCLOSE macro for closing fd automatically

[libvirt] [PATCHv2 0/5] Introduce VIR_AUTOCLOSE macro for closing fd automatically

Posted by Shi Lei 5 years, 7 months ago

v1 here:
https://www.redhat.com/archives/libvir-list/2018-September/msg00319.html

Diff from v1:
  - Change VIR_AUTOCLOSE macro (comments from Michal)
  - Remove others except for patches in util (comments from Erik)
  - Change sc_require_attribute_cleanup_initialization for this macro

Shi Lei (5):
  util: file: introduce VIR_AUTOCLOSE macro to close fd of the file
    automatically
  cfg.mk: Change syntax-check rule for VIR_AUTOCLOSE variable
    initialization
  util: file: use VIR_AUTOCLOSE instead of VIR_FORCE_CLOSE
  util: netdevbridge: use VIR_AUTOCLOSE instead of VIR_FORCE_CLOSE
  util: netdev: use VIR_AUTOCLOSE instead of VIR_FORCE_CLOSE

 cfg.mk                     |   2 +-
 src/util/virfile.c         |  21 ++--
 src/util/virfile.h         |  18 ++-
 src/util/virnetdev.c       | 251 +++++++++++++------------------------
 src/util/virnetdevbridge.c | 120 ++++++------------
 5 files changed, 146 insertions(+), 266 deletions(-)

-- 
2.17.1


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCHv2 0/5] Introduce VIR_AUTOCLOSE macro for closing fd automatically

Posted by Michal Privoznik 5 years, 7 months ago

On 09/12/2018 11:46 AM, Shi Lei wrote:
> v1 here:
> https://www.redhat.com/archives/libvir-list/2018-September/msg00319.html
> 
> Diff from v1:
>   - Change VIR_AUTOCLOSE macro (comments from Michal)
>   - Remove others except for patches in util (comments from Erik)
>   - Change sc_require_attribute_cleanup_initialization for this macro
> 
> Shi Lei (5):
>   util: file: introduce VIR_AUTOCLOSE macro to close fd of the file
>     automatically
>   cfg.mk: Change syntax-check rule for VIR_AUTOCLOSE variable
>     initialization
>   util: file: use VIR_AUTOCLOSE instead of VIR_FORCE_CLOSE
>   util: netdevbridge: use VIR_AUTOCLOSE instead of VIR_FORCE_CLOSE
>   util: netdev: use VIR_AUTOCLOSE instead of VIR_FORCE_CLOSE
> 
>  cfg.mk                     |   2 +-
>  src/util/virfile.c         |  21 ++--
>  src/util/virfile.h         |  18 ++-
>  src/util/virnetdev.c       | 251 +++++++++++++------------------------
>  src/util/virnetdevbridge.c | 120 ++++++------------
>  5 files changed, 146 insertions(+), 266 deletions(-)
> 

ACKed and pushed.

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list