[libvirt] [libvirt PATCH v5 0/1] Finish the conversion to virConfGetValue* functions

Fabiano Fidêncio posted 1 patch 5 years, 7 months ago
Failed in applying to current master (apply log)
There is a newer version of this series
src/xenconfig/xen_common.c | 163 +++++++++++++++++--------------------
1 file changed, 75 insertions(+), 88 deletions(-)
[libvirt] [libvirt PATCH v5 0/1] Finish the conversion to virConfGetValue* functions
Posted by Fabiano Fidêncio 5 years, 7 months ago
This patchset finishes the conversion to virConfGetValue* functions,
started by Daniel Berrange a few months ago.

Please, mind that although we could make virConfGetValue* functions more
generic in order to support numbers and booleans as strings, that
doesn't seem the safest path to take. The side-effect of this is that we
will have to live with some specific code doing that as part of vmx and
xen_common.

Once this patchset gets merged,
https://wiki.libvirt.org/page/BiteSizedTasks#Finish_conversion_to_virConfGetValue.2A_functions
can be removed.

- Changes since v1:
  All the "values" from virConfGetValueString() are freed

- Changes since v2:
  All comments from Ján Tomko have been addressed;
  A few leaks were (possibly) found and they're addressed in the last
  patch of the series;

- Changes since v3:
  All comments from Ján Tomko have been addressed in order to lower the
  non-whitespace changes in the first patch;

- Chages since v4:
  All comments from Ján Tomko have been addressed (hopefully, they
  actually were this time :-));

Fabiano Fidêncio (1):
  xen_common: Convert to typesafe virConf acessors

 src/xenconfig/xen_common.c | 163 +++++++++++++++++--------------------
 1 file changed, 75 insertions(+), 88 deletions(-)

-- 
2.17.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list