Enable libosinfo tests that require network connectivity

[libvirt] [jenkins-ci PATCH v2 0/2] Enable libosinfo tests that require network connectivity

Posted by Fabiano Fidêncio 5 years, 7 months ago

Let's enable both media and tree uris tests in order to early catch URL
changes that need to be fixed in osinfo-db.

Fabiano Fidêncio (2):
  guests: Enable {media,tree}uris tests for libosinfo
  projects: Enable {media,tree}uri tests for libosinfo

 guests/playbooks/build/projects/libosinfo.yml | 4 ++++
 projects/libosinfo.yaml                       | 3 +++
 2 files changed, 7 insertions(+)

-- 
2.17.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [jenkins-ci PATCH v2 0/2] Enable libosinfo tests that require network connectivity

Posted by Andrea Bolognani 5 years, 7 months ago

On Tue, 2018-09-11 at 09:36 +0200, Fabiano Fidêncio wrote:
> Let's enable both media and tree uris tests in order to early catch URL
> changes that need to be fixed in osinfo-db.
> 
> Fabiano Fidêncio (2):
>   guests: Enable {media,tree}uris tests for libosinfo
>   projects: Enable {media,tree}uri tests for libosinfo
> 
>  guests/playbooks/build/projects/libosinfo.yml | 4 ++++
>  projects/libosinfo.yaml                       | 3 +++
>  2 files changed, 7 insertions(+)

So I guess libosinfo has been fixed in the meantime?

Assuming that's the case and that you squash the two patches
together[1],

  Reviewed-by: Andrea Bolognani <abologna@redhat.com>


[1] We've been mostly doing that since introducing the build
    playbooks, as changing both Jenkins and Ansible at the same
    time makes it obvious that they're being kept in sync.
-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [jenkins-ci PATCH v2 0/2] Enable libosinfo tests that require network connectivity

Posted by Fabiano Fidêncio 5 years, 7 months ago

On Wed, Sep 12, 2018 at 12:29 PM, Andrea Bolognani <abologna@redhat.com>
wrote:

> On Tue, 2018-09-11 at 09:36 +0200, Fabiano Fidêncio wrote:
> > Let's enable both media and tree uris tests in order to early catch URL
> > changes that need to be fixed in osinfo-db.
> >
> > Fabiano Fidêncio (2):
> >   guests: Enable {media,tree}uris tests for libosinfo
> >   projects: Enable {media,tree}uri tests for libosinfo
> >
> >  guests/playbooks/build/projects/libosinfo.yml | 4 ++++
> >  projects/libosinfo.yaml                       | 3 +++
> >  2 files changed, 7 insertions(+)
>
> So I guess libosinfo has been fixed in the meantime?
>

In the end there was no libosinfo issue but a Fedora mirroring issue in our
infra.
And, yes, it's solved now.


>
> Assuming that's the case and that you squash the two patches
> together[1],
>

As I don't have commit rights, would you mind squashing the patches efore
pushing them?


>
>   Reviewed-by: Andrea Bolognani <abologna@redhat.com>
>
>
> [1] We've been mostly doing that since introducing the build
>     playbooks, as changing both Jenkins and Ansible at the same
>     time makes it obvious that they're being kept in sync.
> --
> Andrea Bolognani / Red Hat / Virtualization
>
>
Best Regards,
-- 
Fabiano Fidêncio
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [jenkins-ci PATCH v2 0/2] Enable libosinfo tests that require network connectivity

Posted by Andrea Bolognani 5 years, 7 months ago

On Wed, 2018-09-12 at 14:23 +0200, Fabiano Fidêncio wrote:
> On Wed, Sep 12, 2018 at 12:29 PM, Andrea Bolognani <abologna@redhat.com> wrote:
> > Assuming that's the case and that you squash the two patches
> > together[1],
> 
> As I don't have commit rights, would you mind squashing the patches efore pushing them?

Squashed, pushed, and changes applied to Jenkins :)

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list