[v2] qemu: Unify generation of command line for virtio devices

[libvirt] [PATCH v2 4/7] qemu: Always format iothread for virtio-blk

Posted by Andrea Bolognani 7 years, 5 months ago

So far we've only formatted it for virtio-blk-pci and
virtio-blk-ccw, but other virtio-blk devices also support
the corresponding option; moreover, we've always formatted
it for all virtio-scsi devices.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 src/qemu/qemu_command.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index b283f7ca83..e5743fad9d 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -2014,11 +2014,8 @@ qemuBuildDiskDeviceStr(const virDomainDef *def,
             virBufferAddLit(&opt, "virtio-blk-pci");
         }
 
-        if (disk->iothread &&
-            (disk->info.type == VIR_DOMAIN_DEVICE_ADDRESS_TYPE_CCW ||
-             disk->info.type == VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI)) {
+        if (disk->iothread)
             virBufferAsprintf(&opt, ",iothread=iothread%u", disk->iothread);
-        }
 
         qemuBuildIoEventFdStr(&opt, disk->ioeventfd, qemuCaps);
         if (disk->event_idx &&
-- 
2.17.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 4/7] qemu: Always format iothread for virtio-blk

Posted by Ján Tomko 7 years, 5 months ago

On Thu, Sep 06, 2018 at 02:22:16PM +0200, Andrea Bolognani wrote:
>So far we've only formatted it for virtio-blk-pci and
>virtio-blk-ccw, but other virtio-blk devices also support
>the corresponding option; moreover, we've always formatted
>it for all virtio-scsi devices.
>
>Signed-off-by: Andrea Bolognani <abologna@redhat.com>
>---
> src/qemu/qemu_command.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list