guests: Hash test user password dynamically

[libvirt] [jenkins-ci PATCH] guests: Hash test user password dynamically

Posted by Andrea Bolognani 6 years, 2 months ago

Current versions of Ansible support the password_hash()
filter, so we can avoid hardcoding a pre-computed hash
and make what's happening a bit clearer.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 guests/playbooks/update/tasks/users.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/guests/playbooks/update/tasks/users.yml b/guests/playbooks/update/tasks/users.yml
index 0a930d6..abaeaa4 100644
--- a/guests/playbooks/update/tasks/users.yml
+++ b/guests/playbooks/update/tasks/users.yml
@@ -28,7 +28,7 @@
 - name: '{{ flavor }}: Set password'
   user:
     name: '{{ flavor }}'
-    password: '$6$xSlfvkcsDgPmRAMX$mFh9qRmFFW9cyW1n5/jeHvq4OmJA8WzSD70Mfis3VHc3Z5imZeiQAg9VNL4sFEtmDy/siU3nJL.QeAapCgfL20'
+    password: '{{ "test"|password_hash("sha512") }}'
   when:
     - flavor == 'test'
 
-- 
2.17.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [jenkins-ci PATCH] guests: Hash test user password dynamically

Posted by Andrea Bolognani 6 years, 2 months ago

Ping? :)

On Tue, 2018-09-04 at 14:34 +0200, Andrea Bolognani wrote:
> Current versions of Ansible support the password_hash()
> filter, so we can avoid hardcoding a pre-computed hash
> and make what's happening a bit clearer.
> 
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---
>  guests/playbooks/update/tasks/users.yml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/guests/playbooks/update/tasks/users.yml
> b/guests/playbooks/update/tasks/users.yml
> index 0a930d6..abaeaa4 100644
> --- a/guests/playbooks/update/tasks/users.yml
> +++ b/guests/playbooks/update/tasks/users.yml
> @@ -28,7 +28,7 @@
>  - name: '{{ flavor }}: Set password'
>    user:
>      name: '{{ flavor }}'
> -    password:
> '$6$xSlfvkcsDgPmRAMX$mFh9qRmFFW9cyW1n5/jeHvq4OmJA8WzSD70Mfis3VHc3Z5im
> ZeiQAg9VNL4sFEtmDy/siU3nJL.QeAapCgfL20'
> +    password: '{{ "test"|password_hash("sha512") }}'
>    when:
>      - flavor == 'test'
>  
-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [jenkins-ci PATCH] guests: Hash test user password dynamically

Posted by Fabiano Fidêncio 6 years, 2 months ago

On Tue, Sep 4, 2018 at 2:34 PM, Andrea Bolognani <abologna@redhat.com>
wrote:

> Current versions of Ansible support the password_hash()
> filter, so we can avoid hardcoding a pre-computed hash
> and make what's happening a bit clearer.
>
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
>

Reviewed-by: Fabiano Fidêncio <fidencio@redhat.com>


> ---
>  guests/playbooks/update/tasks/users.yml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/guests/playbooks/update/tasks/users.yml
> b/guests/playbooks/update/tasks/users.yml
> index 0a930d6..abaeaa4 100644
> --- a/guests/playbooks/update/tasks/users.yml
> +++ b/guests/playbooks/update/tasks/users.yml
> @@ -28,7 +28,7 @@
>  - name: '{{ flavor }}: Set password'
>    user:
>      name: '{{ flavor }}'
> -    password: '$6$xSlfvkcsDgPmRAMX$mFh9qRmFFW9cyW1n5/
> jeHvq4OmJA8WzSD70Mfis3VHc3Z5imZeiQAg9VNL4sFEtmDy/siU3nJL.QeAapCgfL20'
> +    password: '{{ "test"|password_hash("sha512") }}'
>    when:
>      - flavor == 'test'
>
> --
> 2.17.1
>
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
>
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list