[libvirt] [PATCH v3 6/9] qemu: add qemuDomainAssignVirtioMMIOAddresses()

Lubomir Rintel posted 9 patches 7 years, 5 months ago
Only 8 patches received!
[libvirt] [PATCH v3 6/9] qemu: add qemuDomainAssignVirtioMMIOAddresses()
Posted by Lubomir Rintel 7 years, 5 months ago
Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
---
 src/qemu/qemu_domain_address.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/src/qemu/qemu_domain_address.c b/src/qemu/qemu_domain_address.c
index 551883e989..317f280f92 100644
--- a/src/qemu/qemu_domain_address.c
+++ b/src/qemu/qemu_domain_address.c
@@ -485,6 +485,14 @@ qemuDomainAssignARMVirtioMMIOAddresses(virDomainDefPtr def,
 }
 
 
+static void
+qemuDomainAssignVirtioMMIOAddresses(virDomainDefPtr def,
+                                    virQEMUCapsPtr qemuCaps)
+{
+    qemuDomainAssignARMVirtioMMIOAddresses(def, qemuCaps);
+}
+
+
 /**
  * qemuDomainDeviceCalculatePCIConnectFlags:
  *
@@ -2923,7 +2931,7 @@ qemuDomainAssignAddresses(virDomainDefPtr def,
     if (qemuDomainAssignS390Addresses(def, qemuCaps) < 0)
         return -1;
 
-    qemuDomainAssignARMVirtioMMIOAddresses(def, qemuCaps);
+    qemuDomainAssignVirtioMMIOAddresses(def, qemuCaps);
 
     if (qemuDomainAssignPCIAddresses(def, qemuCaps, driver, obj) < 0)
         return -1;
-- 
2.17.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v3 6/9] qemu: add qemuDomainAssignVirtioMMIOAddresses()
Posted by Andrea Bolognani 7 years, 5 months ago
On Wed, 2018-08-22 at 11:15 +0200, Lubomir Rintel wrote:

A short not explaining why you need to do this, along the lines of

  We're going to need to assign virtio-mmio addresses to non-ARM
  guests soon, so let's create a generic wrapper that calls to
  the architecture-specific implementation.

sure would be nice... Are you okay with me adding it to the commit
message before pushing?

Either way the code is fine, so

  Reviewed-by: Andrea Bolognani <abologna@redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v3 6/9] qemu: add qemuDomainAssignVirtioMMIOAddresses()
Posted by Lubomir Rintel 7 years, 5 months ago
On Thu, 2018-08-23 at 17:43 +0200, Andrea Bolognani wrote:
> On Wed, 2018-08-22 at 11:15 +0200, Lubomir Rintel wrote:
> 
> A short not explaining why you need to do this, along the lines of
> 
>   We're going to need to assign virtio-mmio addresses to non-ARM
>   guests soon, so let's create a generic wrapper that calls to
>   the architecture-specific implementation.
> 
> sure would be nice... Are you okay with me adding it to the commit
> message before pushing?

Yes, that would be fine.

> 
> Either way the code is fine, so
> 
>   Reviewed-by: Andrea Bolognani <abologna@redhat.com>

Thanks,
Lubo

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list