[libvirt] [PATCH 0/3] Allow inputvol when creating vol from inputvol to be encrypted

John Ferlan posted 3 patches 6 years, 3 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20180821162317.31638-1-jferlan@redhat.com
Test syntax-check passed
src/storage/storage_util.c                    | 79 ++++++++++++++++---
src/storage/storage_util.h                    |  1 +
.../luks-convert-encrypt.argv                 | 11 +++
.../luks-convert-encrypt2fileqcow2.argv       |  7 ++
.../luks-convert-encrypt2fileraw.argv         |  7 ++
.../luks-convert-qcow2.argv                   |  9 +++
tests/storagevolxml2argvtest.c                | 19 ++++-
tests/storagevolxml2xmlin/vol-encrypt1.xml    | 21 +++++
tests/storagevolxml2xmlin/vol-encrypt2.xml    | 21 +++++
tests/storagevolxml2xmlin/vol-file-qcow2.xml  | 21 +++++
10 files changed, 184 insertions(+), 12 deletions(-)
create mode 100644 tests/storagevolxml2argvdata/luks-convert-encrypt.argv
create mode 100644 tests/storagevolxml2argvdata/luks-convert-encrypt2fileqcow2.argv
create mode 100644 tests/storagevolxml2argvdata/luks-convert-encrypt2fileraw.argv
create mode 100644 tests/storagevolxml2argvdata/luks-convert-qcow2.argv
create mode 100644 tests/storagevolxml2xmlin/vol-encrypt1.xml
create mode 100644 tests/storagevolxml2xmlin/vol-encrypt2.xml
create mode 100644 tests/storagevolxml2xmlin/vol-file-qcow2.xml
[libvirt] [PATCH 0/3] Allow inputvol when creating vol from inputvol to be encrypted
Posted by John Ferlan 6 years, 3 months ago
https://bugzilla.redhat.com/show_bug.cgi?id=1613737

Details in the patches (and even more in the bz).

John Ferlan (3):
  storage: Remove secretPath from _virStorageBackendQemuImgInfo
  storage: Allow for inputvol to have any format for encryption
  storage: Allow inputvol to be encrypted

 src/storage/storage_util.c                    | 79 ++++++++++++++++---
 src/storage/storage_util.h                    |  1 +
 .../luks-convert-encrypt.argv                 | 11 +++
 .../luks-convert-encrypt2fileqcow2.argv       |  7 ++
 .../luks-convert-encrypt2fileraw.argv         |  7 ++
 .../luks-convert-qcow2.argv                   |  9 +++
 tests/storagevolxml2argvtest.c                | 19 ++++-
 tests/storagevolxml2xmlin/vol-encrypt1.xml    | 21 +++++
 tests/storagevolxml2xmlin/vol-encrypt2.xml    | 21 +++++
 tests/storagevolxml2xmlin/vol-file-qcow2.xml  | 21 +++++
 10 files changed, 184 insertions(+), 12 deletions(-)
 create mode 100644 tests/storagevolxml2argvdata/luks-convert-encrypt.argv
 create mode 100644 tests/storagevolxml2argvdata/luks-convert-encrypt2fileqcow2.argv
 create mode 100644 tests/storagevolxml2argvdata/luks-convert-encrypt2fileraw.argv
 create mode 100644 tests/storagevolxml2argvdata/luks-convert-qcow2.argv
 create mode 100644 tests/storagevolxml2xmlin/vol-encrypt1.xml
 create mode 100644 tests/storagevolxml2xmlin/vol-encrypt2.xml
 create mode 100644 tests/storagevolxml2xmlin/vol-file-qcow2.xml

-- 
2.17.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 0/3] Allow inputvol when creating vol from inputvol to be encrypted
Posted by John Ferlan 6 years, 3 months ago
ping?

Tks -

John

On 08/21/2018 12:23 PM, John Ferlan wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1613737
> 
> Details in the patches (and even more in the bz).
> 
> John Ferlan (3):
>   storage: Remove secretPath from _virStorageBackendQemuImgInfo
>   storage: Allow for inputvol to have any format for encryption
>   storage: Allow inputvol to be encrypted
> 
>  src/storage/storage_util.c                    | 79 ++++++++++++++++---
>  src/storage/storage_util.h                    |  1 +
>  .../luks-convert-encrypt.argv                 | 11 +++
>  .../luks-convert-encrypt2fileqcow2.argv       |  7 ++
>  .../luks-convert-encrypt2fileraw.argv         |  7 ++
>  .../luks-convert-qcow2.argv                   |  9 +++
>  tests/storagevolxml2argvtest.c                | 19 ++++-
>  tests/storagevolxml2xmlin/vol-encrypt1.xml    | 21 +++++
>  tests/storagevolxml2xmlin/vol-encrypt2.xml    | 21 +++++
>  tests/storagevolxml2xmlin/vol-file-qcow2.xml  | 21 +++++
>  10 files changed, 184 insertions(+), 12 deletions(-)
>  create mode 100644 tests/storagevolxml2argvdata/luks-convert-encrypt.argv
>  create mode 100644 tests/storagevolxml2argvdata/luks-convert-encrypt2fileqcow2.argv
>  create mode 100644 tests/storagevolxml2argvdata/luks-convert-encrypt2fileraw.argv
>  create mode 100644 tests/storagevolxml2argvdata/luks-convert-qcow2.argv
>  create mode 100644 tests/storagevolxml2xmlin/vol-encrypt1.xml
>  create mode 100644 tests/storagevolxml2xmlin/vol-encrypt2.xml
>  create mode 100644 tests/storagevolxml2xmlin/vol-file-qcow2.xml
> 

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 0/3] Allow inputvol when creating vol from inputvol to be encrypted
Posted by John Ferlan 6 years, 2 months ago
ping^2?

Tks,

John

On 08/24/2018 10:27 AM, John Ferlan wrote:
> 
> ping?
> 
> Tks -
> 
> John
> 
> On 08/21/2018 12:23 PM, John Ferlan wrote:
>> https://bugzilla.redhat.com/show_bug.cgi?id=1613737
>>
>> Details in the patches (and even more in the bz).
>>
>> John Ferlan (3):
>>   storage: Remove secretPath from _virStorageBackendQemuImgInfo
>>   storage: Allow for inputvol to have any format for encryption
>>   storage: Allow inputvol to be encrypted
>>
>>  src/storage/storage_util.c                    | 79 ++++++++++++++++---
>>  src/storage/storage_util.h                    |  1 +
>>  .../luks-convert-encrypt.argv                 | 11 +++
>>  .../luks-convert-encrypt2fileqcow2.argv       |  7 ++
>>  .../luks-convert-encrypt2fileraw.argv         |  7 ++
>>  .../luks-convert-qcow2.argv                   |  9 +++
>>  tests/storagevolxml2argvtest.c                | 19 ++++-
>>  tests/storagevolxml2xmlin/vol-encrypt1.xml    | 21 +++++
>>  tests/storagevolxml2xmlin/vol-encrypt2.xml    | 21 +++++
>>  tests/storagevolxml2xmlin/vol-file-qcow2.xml  | 21 +++++
>>  10 files changed, 184 insertions(+), 12 deletions(-)
>>  create mode 100644 tests/storagevolxml2argvdata/luks-convert-encrypt.argv
>>  create mode 100644 tests/storagevolxml2argvdata/luks-convert-encrypt2fileqcow2.argv
>>  create mode 100644 tests/storagevolxml2argvdata/luks-convert-encrypt2fileraw.argv
>>  create mode 100644 tests/storagevolxml2argvdata/luks-convert-qcow2.argv
>>  create mode 100644 tests/storagevolxml2xmlin/vol-encrypt1.xml
>>  create mode 100644 tests/storagevolxml2xmlin/vol-encrypt2.xml
>>  create mode 100644 tests/storagevolxml2xmlin/vol-file-qcow2.xml
>>
> 
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
> 

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 0/3] Allow inputvol when creating vol from inputvol to be encrypted
Posted by Michal Privoznik 6 years, 2 months ago
On 08/21/2018 06:23 PM, John Ferlan wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1613737
> 
> Details in the patches (and even more in the bz).
> 
> John Ferlan (3):
>   storage: Remove secretPath from _virStorageBackendQemuImgInfo
>   storage: Allow for inputvol to have any format for encryption
>   storage: Allow inputvol to be encrypted
> 
>  src/storage/storage_util.c                    | 79 ++++++++++++++++---
>  src/storage/storage_util.h                    |  1 +
>  .../luks-convert-encrypt.argv                 | 11 +++
>  .../luks-convert-encrypt2fileqcow2.argv       |  7 ++
>  .../luks-convert-encrypt2fileraw.argv         |  7 ++
>  .../luks-convert-qcow2.argv                   |  9 +++
>  tests/storagevolxml2argvtest.c                | 19 ++++-
>  tests/storagevolxml2xmlin/vol-encrypt1.xml    | 21 +++++
>  tests/storagevolxml2xmlin/vol-encrypt2.xml    | 21 +++++
>  tests/storagevolxml2xmlin/vol-file-qcow2.xml  | 21 +++++
>  10 files changed, 184 insertions(+), 12 deletions(-)
>  create mode 100644 tests/storagevolxml2argvdata/luks-convert-encrypt.argv
>  create mode 100644 tests/storagevolxml2argvdata/luks-convert-encrypt2fileqcow2.argv
>  create mode 100644 tests/storagevolxml2argvdata/luks-convert-encrypt2fileraw.argv
>  create mode 100644 tests/storagevolxml2argvdata/luks-convert-qcow2.argv
>  create mode 100644 tests/storagevolxml2xmlin/vol-encrypt1.xml
>  create mode 100644 tests/storagevolxml2xmlin/vol-encrypt2.xml
>  create mode 100644 tests/storagevolxml2xmlin/vol-file-qcow2.xml
> 

ACK bu see my comments before pushing.

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list