spec: Add support for RISC-V (riscv64)

[libvirt] [PATCH] spec: Add support for RISC-V (riscv64)

Richard W.M. Jones posted 1 patch 5 years, 8 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20180820085949.8395-1-rjones@redhat.com

Test syntax-check passed

libvirt.spec.in | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

Expand all Fold all

[libvirt] [PATCH] spec: Add support for RISC-V (riscv64)

Posted by Richard W.M. Jones 5 years, 8 months ago

From: David Abdurachmanov <david.abdurachmanov@gmail.com>

---
 libvirt.spec.in | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/libvirt.spec.in b/libvirt.spec.in
index e7196b7d3b..5cb995a6a4 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -101,7 +101,7 @@
 %endif
 
 # Numactl is not available on s390[x] and ARM
-%ifarch s390 s390x %{arm}
+%ifarch s390 s390x %{arm} riscv64
     %define with_numactl 0
 %endif
 
@@ -120,7 +120,7 @@
 %endif
 
 # zfs-fuse is not available on some architectures
-%ifarch s390 s390x aarch64
+%ifarch s390 s390x aarch64 riscv64
     %define with_storage_zfs 0
 %endif
 
@@ -195,7 +195,7 @@
 %if %{with_qemu} || %{with_lxc} || %{with_uml}
 # numad is used to manage the CPU and memory placement dynamically,
 # it's not available on s390[x] and ARM.
-    %ifnarch s390 s390x %{arm}
+    %ifnarch s390 s390x %{arm} riscv64
         %define with_numad    0%{!?_without_numad:1}
     %endif
 %endif
-- 
2.18.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] spec: Add support for RISC-V (riscv64)

Posted by Andrea Bolognani 5 years, 8 months ago

On Mon, 2018-08-20 at 09:59 +0100, Richard W.M. Jones wrote:
> From: David Abdurachmanov <david.abdurachmanov@gmail.com>

We require a Signed-off-by for libvirt contributions these days,
so we can't merge this patch unless it's provided.

[...]
>  # Numactl is not available on s390[x] and ARM

Comment should be updated to

  numactl is not available on some architectures

[...]
>  # numad is used to manage the CPU and memory placement dynamically,
>  # it's not available on s390[x] and ARM.

Same as above.

Everything else looks good.

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list