We deprecated GTK2 and SDL1.2 in the 2.12.0 release, so they are able to
be removed entirely in the 3.1.0 release. The min GTK3 version can also
be bumped up based the distros we aim to support.

Daniel P. Berrangé (3):
  ui: remove support for GTK2 in favour of GTK3
  ui: increase min required GTK3 version to 3.14.0
  ui: remove support for SDL1.2 in favour of SDL2

 configure              |  111 +----
 include/ui/gtk.h       |    9 -
 qemu-deprecated.texi   |   16 -
 ui/Makefile.objs       |    5 -
 ui/gtk-egl.c           |   10 +-
 ui/gtk.c               |  202 +-------
 ui/sdl.c               | 1027 ----------------------------------------
 ui/sdl_zoom.c          |   93 ----
 ui/sdl_zoom.h          |   25 -
 ui/sdl_zoom_template.h |  219 ---------
 10 files changed, 33 insertions(+), 1684 deletions(-)
 delete mode 100644 ui/sdl.c
 delete mode 100644 ui/sdl_zoom.c
 delete mode 100644 ui/sdl_zoom.h
 delete mode 100644 ui/sdl_zoom_template.h

-- 
2.17.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On Wed, Aug 08, 2018 at 11:49:27AM +0100, Daniel P. Berrangé wrote:
> We deprecated GTK2 and SDL1.2 in the 2.12.0 release, so they are able to
> be removed entirely in the 3.1.0 release. The min GTK3 version can also
> be bumped up based the distros we aim to support.

Doesn't apply any more.
Can you rebase and resend?

thanks,
  Gerd

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On Wed, Aug 08, 2018 at 11:49:27AM +0100, Daniel P. Berrangé wrote:
> We deprecated GTK2 and SDL1.2 in the 2.12.0 release, so they are able to
> be removed entirely in the 3.1.0 release. The min GTK3 version can also
> be bumped up based the distros we aim to support.

Yes for gtk2, finally the #ifdef mess is gone, yay!

Not so sure for sdl1, that one was more controversial and sdl2
regression fixes are still tickling in (although it seems we killed most
of them meanwhile).  Also due to sdl1 being a separate source file
anyway the maintanance costs are not that high.

Comments?

When actually removing sdl1 the -no-frame cmd line switch can go too as
sdl1 is the only user.

cheers,
  Gerd

On Wed, Aug 08, 2018 at 01:24:09PM +0200, Gerd Hoffmann wrote:
> On Wed, Aug 08, 2018 at 11:49:27AM +0100, Daniel P. Berrangé wrote:
> > We deprecated GTK2 and SDL1.2 in the 2.12.0 release, so they are able to
> > be removed entirely in the 3.1.0 release. The min GTK3 version can also
> > be bumped up based the distros we aim to support.
> 
> Yes for gtk2, finally the #ifdef mess is gone, yay!
> 
> Not so sure for sdl1, that one was more controversial and sdl2
> regression fixes are still tickling in (although it seems we killed most
> of them meanwhile).  Also due to sdl1 being a separate source file
> anyway the maintanance costs are not that high.
> 
> Comments?

There were some regressions wrt SDL2, but I don't think there's any
major problems still missing. If there are new problems reported, we
still have the entire of the 3.1.0 dev cycle to address them before
the release which removes it.

Even if code is separate, it still has a maint cost in testing and impacts
any refactoring we do, such as that around keymap handling which is a
non-trivial cost for something that is increasingly unused, since we
default to SDL2 ABI for many releases now. At least GTK2 still had bug-fix
releases for any security problems or serious bugs, but SDL1 has received
no releases at all upstream since 2013

So I don't see any compelling reason to keep it alive given, and enough
downside given that it has been dead in its upstream community for years. 

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|