[v3] PCI passthrough support on s390

[libvirt] [PATCH v3 12/12] news: Update news for PCI address extension attributes

Posted by Yi Min Zhao 7 years, 6 months ago

Signed-off-by: Yi Min Zhao <zyimin@linux.ibm.com>
Reviewed-by: Boris Fiuczynski <fiuczy@linux.vnet.ibm.com>
Reviewed-by: Stefan Zimmermann <stzi@linux.ibm.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
---
 docs/news.xml | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/docs/news.xml b/docs/news.xml
index afafb9c337..545d7c552a 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -44,6 +44,17 @@
           iscsiadm. It support basic pool operations: checkPool and refreshPool.
         </description>
       </change>
+      <change>
+        <summary>
+          qemu: Added support for PCI device passthrough on S390
+        </summary>
+        <description>
+          The new zPCI attributes uid (user-defined identifier)
+          and fid (PCI function identifier) of the S390 platform
+          extend the PCI device address to support the PCI
+          passthrough on S390.
+        </description>
+      </change>
     </section>
     <section title="Improvements">
     </section>
-- 
Yi Min

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v3 12/12] news: Update news for PCI address extension attributes

Posted by Andrea Bolognani 7 years, 5 months ago

On Tue, 2018-08-07 at 17:10 +0800, Yi Min Zhao wrote:
[...]
> +      <change>
> +        <summary>
> +          qemu: Added support for PCI device passthrough on S390
> +        </summary>
> +        <description>
> +          The new zPCI attributes uid (user-defined identifier)
> +          and fid (PCI function identifier) of the S390 platform
> +          extend the PCI device address to support the PCI
> +          passthrough on S390.
> +        </description>
> +      </change>

This doesn't look entirely accurate: the attributes are not only
used for assigned devices but for emulated devices as well, so
the text should reflect that.

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v3 12/12] news: Update news for PCI address extension attributes

Posted by Yi Min Zhao 7 years, 5 months ago


在 2018/8/18 上午12:21, Andrea Bolognani 写道:
> On Tue, 2018-08-07 at 17:10 +0800, Yi Min Zhao wrote:
> [...]
>> +      <change>
>> +        <summary>
>> +          qemu: Added support for PCI device passthrough on S390
>> +        </summary>
>> +        <description>
>> +          The new zPCI attributes uid (user-defined identifier)
>> +          and fid (PCI function identifier) of the S390 platform
>> +          extend the PCI device address to support the PCI
>> +          passthrough on S390.
>> +        </description>
>> +      </change>
> This doesn't look entirely accurate: the attributes are not only
> used for assigned devices but for emulated devices as well, so
> the text should reflect that.
>
How about:

*** to support the PCI functionality on S390.

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v3 12/12] news: Update news for PCI address extension attributes

Posted by Andrea Bolognani 7 years, 5 months ago

On Mon, 2018-08-20 at 11:39 +0800, Yi Min Zhao wrote:
> 在 2018/8/18 上午12:21, Andrea Bolognani 写道:
> > On Tue, 2018-08-07 at 17:10 +0800, Yi Min Zhao wrote:
> > [...]
> > > +      <change>
> > > +        <summary>
> > > +          qemu: Added support for PCI device passthrough on S390
> > > +        </summary>
> > > +        <description>
> > > +          The new zPCI attributes uid (user-defined identifier)
> > > +          and fid (PCI function identifier) of the S390 platform
> > > +          extend the PCI device address to support the PCI
> > > +          passthrough on S390.
> > > +        </description>
> > > +      </change>
> > 
> > This doesn't look entirely accurate: the attributes are not only
> > used for assigned devices but for emulated devices as well, so
> > the text should reflect that.
> 
> How about:
> 
> *** to support the PCI functionality on S390.

Perhaps something like

  qemu: Added support for PCI devices on s390

  PCI addresses can now include the new uid (user-defined
  identifier) and fid (PCI function identifier) attributes, which
  make the corresponding devices usable by s390 guests.

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v3 12/12] news: Update news for PCI address extension attributes

Posted by Yi Min Zhao 7 years, 5 months ago


在 2018/8/20 下午6:17, Andrea Bolognani 写道:
> On Mon, 2018-08-20 at 11:39 +0800, Yi Min Zhao wrote:
>> 在 2018/8/18 上午12:21, Andrea Bolognani 写道:
>>> On Tue, 2018-08-07 at 17:10 +0800, Yi Min Zhao wrote:
>>> [...]
>>>> +      <change>
>>>> +        <summary>
>>>> +          qemu: Added support for PCI device passthrough on S390
>>>> +        </summary>
>>>> +        <description>
>>>> +          The new zPCI attributes uid (user-defined identifier)
>>>> +          and fid (PCI function identifier) of the S390 platform
>>>> +          extend the PCI device address to support the PCI
>>>> +          passthrough on S390.
>>>> +        </description>
>>>> +      </change>
>>> This doesn't look entirely accurate: the attributes are not only
>>> used for assigned devices but for emulated devices as well, so
>>> the text should reflect that.
>> How about:
>>
>> *** to support the PCI functionality on S390.
> Perhaps something like
>
>    qemu: Added support for PCI devices on s390
>
>    PCI addresses can now include the new uid (user-defined
>    identifier) and fid (PCI function identifier) attributes, which
>    make the corresponding devices usable by s390 guests.
>
Better, I will do a little update based on your words.

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list