qemu: emit error when trying to update blkiotune group_name in qemuDomainChangeDiskLive

[libvirt] [PATCH] qemu: emit error when trying to update blkiotune group_name in qemuDomainChangeDiskLive

Posted by Katerina Koukiou 5 years, 9 months ago

All rest of blkiotune parameters are not updatable through UpdateDeviceFlags API.

https://bugzilla.redhat.com/show_bug.cgi?id=1601677

Signed-off-by: Katerina Koukiou <kkoukiou@redhat.com>
---

The BZ was requesting to add support for updating the group_name for
blkdeviotune here, though, all the rest of blkdeviotune elements are not
updatable though UpdateDeviceFlags API. I think emmiting error and
keeping all blkiodevtune parameters updatable in a consistent way is the
right way to go.

 src/qemu/qemu_domain.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index de056272e8..0aa440e0b5 100644
--- a/src/qemu/qemu_domain.c
+++ b/src/qemu/qemu_domain.c
@@ -8791,6 +8791,9 @@ qemuDomainDiskChangeSupported(virDomainDiskDefPtr disk,
     CHECK_EQ(blkdeviotune.size_iops_sec,
              "blkdeviotune size_iops_sec",
              true);
+    CHECK_EQ(blkdeviotune.group_name,
+             "blkdeviotune group_name",
+             true);
 
     if (disk->serial && STRNEQ_NULLABLE(disk->serial, orig_disk->serial)) {
         virReportError(VIR_ERR_OPERATION_UNSUPPORTED,
-- 
2.17.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] qemu: emit error when trying to update blkiotune group_name in qemuDomainChangeDiskLive

Posted by Ján Tomko 5 years, 8 months ago

On Tue, Jul 31, 2018 at 09:36:26AM +0200, Katerina Koukiou wrote:
>All rest of blkiotune parameters are not updatable through UpdateDeviceFlags API.
>

s/All rest/The rest/

>https://bugzilla.redhat.com/show_bug.cgi?id=1601677
>
>Signed-off-by: Katerina Koukiou <kkoukiou@redhat.com>
>---
>
>The BZ was requesting to add support for updating the group_name for
>blkdeviotune here, though, all the rest of blkdeviotune elements are not
>updatable though UpdateDeviceFlags API. I think emmiting error and
>keeping all blkiodevtune parameters updatable in a consistent way is the
>right way to go.
>
> src/qemu/qemu_domain.c | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
>index de056272e8..0aa440e0b5 100644
>--- a/src/qemu/qemu_domain.c
>+++ b/src/qemu/qemu_domain.c
>@@ -8791,6 +8791,9 @@ qemuDomainDiskChangeSupported(virDomainDiskDefPtr disk,
>     CHECK_EQ(blkdeviotune.size_iops_sec,
>              "blkdeviotune size_iops_sec",
>              true);
>+    CHECK_EQ(blkdeviotune.group_name,
>+             "blkdeviotune group_name",
>+             true);
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list