Patch series
https://www.redhat.com/archives/libvir-list/2016-January/msg00482.html
introduced the parameters but didn't update the docs.

Signed-off-by: Katerina Koukiou <kkoukiou@redhat.com>
---
 docs/formatdomain.html.in | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index a3afe137bf..7fa448acdc 100644
--- a/docs/formatdomain.html.in
+++ b/docs/formatdomain.html.in
@@ -747,6 +747,8 @@
     &lt;shares&gt;2048&lt;/shares&gt;
     &lt;period&gt;1000000&lt;/period&gt;
     &lt;quota&gt;-1&lt;/quota&gt;
+    &lt;global_period&gt;1000000&lt;/global_period&gt;
+    &lt;global_quota&gt;-1&lt;/global_quota&gt;
     &lt;emulator_period&gt;1000000&lt;/emulator_period&gt;
     &lt;emulator_quota&gt;-1&lt;/emulator_quota&gt;
     &lt;iothread_period&gt;1000000&lt;/iothread_period&gt;
@@ -837,6 +839,25 @@
         <span class="since">Only QEMU driver support since 0.9.4, LXC since
         0.9.10</span>
       </dd>
+      <dt><code>global_period</code></dt>
+      <dd>
+        The optional <code>global_period</code> element specifies the
+        enforcement period for a quota (unit: microseconds) for whole domain,
+        when using posix scheduler. The value should be in range
+        [1000, 1000000]. A global_period with value 0 means no value.
+        <span class="since">Only QEMU driver support since 1.3.3</span>
+      </dd>
+      <dt><code>global_quota</code></dt>
+      <dd>
+        The optional <code>global_quota</code> element specifies the maximum
+        allowed bandwidth (unit: microseconds) to be used within a period for
+        whole domain. A domain with <code>global_quota</code> as any negative
+        value indicates that the domain has infinite bandwidth, which means that
+        it is not bandwidth controlled. The value should be in range
+        [1000, 18446744073709551] or less than 0. A global_quota with value 0
+        means no value.
+        <span class="since">Only QEMU driver support since 1.3.3</span>
+      </dd>
 
       <dt><code>emulator_period</code></dt>
       <dd>
-- 
2.17.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On Tue, Jul 17, 2018 at 05:47:31PM +0200, Katerina Koukiou wrote:
> Patch series
> https://www.redhat.com/archives/libvir-list/2016-January/msg00482.html

The commit hashes would be better IMO, i.e. commits 4d92d5 and 55ecda.

> introduced the parameters but didn't update the docs.

>
> Signed-off-by: Katerina Koukiou <kkoukiou@redhat.com>
> ---
>  docs/formatdomain.html.in | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
>
> diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
> index a3afe137bf..7fa448acdc 100644
> --- a/docs/formatdomain.html.in
> +++ b/docs/formatdomain.html.in
> @@ -747,6 +747,8 @@
>      &lt;shares&gt;2048&lt;/shares&gt;
>      &lt;period&gt;1000000&lt;/period&gt;
>      &lt;quota&gt;-1&lt;/quota&gt;
> +    &lt;global_period&gt;1000000&lt;/global_period&gt;
> +    &lt;global_quota&gt;-1&lt;/global_quota&gt;
>      &lt;emulator_period&gt;1000000&lt;/emulator_period&gt;
>      &lt;emulator_quota&gt;-1&lt;/emulator_quota&gt;
>      &lt;iothread_period&gt;1000000&lt;/iothread_period&gt;
> @@ -837,6 +839,25 @@
>          <span class="since">Only QEMU driver support since 0.9.4, LXC since
>          0.9.10</span>
>        </dd>
> +      <dt><code>global_period</code></dt>
> +      <dd>
> +        The optional <code>global_period</code> element specifies the
> +        enforcement period for a quota (unit: microseconds) for whole domain,
> +        when using posix scheduler. The value should be in range

s/ whole/the whole/

How about "... element specifies the enforcement CFS scheduler interval for the
whole domain in contrast with <period> which enforces the interval per vcpu."

> +        [1000, 1000000]. A global_period with value 0 means no value.

s/\(global_period\)/<code>\1</code>/

> +        <span class="since">Only QEMU driver support since 1.3.3</span>

^This bit can stay as is.

> +      </dd>
> +      <dt><code>global_quota</code></dt>
> +      <dd>
> +        The optional <code>global_quota</code> element specifies the maximum
> +        allowed bandwidth (unit: microseconds) to be used within a period for

s/to be used//
s/ whole/the whole/

> +        whole domain. A domain with <code>global_quota</code> as any negative
> +        value indicates that the domain has infinite bandwidth, which means that
> +        it is not bandwidth controlled. The value should be in range
> +        [1000, 18446744073709551] or less than 0. A global_quota with value 0
> +        means no value.

s/\(global_quota\)/<code>\1</code>/

> +        <span class="since">Only QEMU driver support since 1.3.3</span>
> +      </dd>
>
>        <dt><code>emulator_period</code></dt>
>        <dd>
> --

Reviewed-by: Erik Skultety <eskultet@redhat.com>

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list