qemu: hotplug: report error when changing rom enabled attr for net iface

[libvirt] [PATCH] qemu: hotplug: report error when changing rom enabled attr for net iface

Posted by Katerina Koukiou 5 years, 9 months ago

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1599513

Signed-off-by: Katerina Koukiou <kkoukiou@redhat.com>
---
 src/qemu/qemu_hotplug.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
index 3dfa51b0a0..bb50d19c85 100644
--- a/src/qemu/qemu_hotplug.c
+++ b/src/qemu/qemu_hotplug.c
@@ -3222,6 +3222,11 @@ qemuDomainChangeNet(virQEMUDriverPtr driver,
                        _("cannot modify network device boot index setting"));
         goto cleanup;
     }
+    if (olddev->info.romenabled != newdev->info.romenabled) {
+        virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s",
+                       _("cannot modify network device rom enabled setting"));
+        goto cleanup;
+    }
     /* (end of device info checks) */
 
     if (STRNEQ_NULLABLE(olddev->filter, newdev->filter) ||
-- 
2.15.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] qemu: hotplug: report error when changing rom enabled attr for net iface

Posted by Ján Tomko 5 years, 9 months ago

On Fri, Jul 13, 2018 at 03:57:04PM +0200, Katerina Koukiou wrote:
>Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1599513
>

The 'Resolves: ' prefix is still pointless, but Andrea might try to disagree

>Signed-off-by: Katerina Koukiou <kkoukiou@redhat.com>
>---
> src/qemu/qemu_hotplug.c | 5 +++++
> 1 file changed, 5 insertions(+)
>

If you add yourself to the maintainers list:

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] qemu: hotplug: report error when changing rom enabled attr for net iface

Posted by Andrea Bolognani 5 years, 9 months ago

On Fri, 2018-07-13 at 16:07 +0200, Ján Tomko wrote:
> On Fri, Jul 13, 2018 at 03:57:04PM +0200, Katerina Koukiou wrote:
> > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1599513
> 
> The 'Resolves: ' prefix is still pointless, but Andrea might try to disagree

Nah, I'm good :)

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list