[libvirt] [PATCH 0/5] Making libvirt aware of a server need

Marcos Paulo de Souza posted 5 patches 11 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20180709162223.5239-1-marcos.souza.org@gmail.com
Test syntax-check passed
src/driver.h               | 2 ++
src/esx/esx_driver.c       | 8 +-------
src/hyperv/hyperv_driver.c | 8 +-------
src/libvirt.c              | 5 +++++
src/phyp/phyp_driver.c     | 7 +------
5 files changed, 10 insertions(+), 20 deletions(-)

[libvirt] [PATCH 0/5] Making libvirt aware of a server need

Posted by Marcos Paulo de Souza 11 weeks ago
Hi guys,

this is basically a second version of [1], but I rewrote the patch following
Matthias ideas [2]. It really seems a cleaner change, but, feel free to suggest
any other change that could make the code better.

I did a lot of tests using virsh tool, so when using the ESX driver without a
proper server, it returns a error. I could not test hyperv and phyp.

Thanks,

[1]: https://www.redhat.com/archives/libvir-list/2018-July/msg00393.html
[2]: https://www.redhat.com/archives/libvir-list/2018-July/msg00400.html

Marcos Paulo de Souza (5):
  driver.h: Add remoteOnly member to virConnectDriver struct
  libvirt.c: Return error when remoteOnly is set but server is empty
  esx_driver: Set remoteOnly member of virConnectDriver
  hyperv_driver: Set remoteOnly member of virConnectDriver
  phyp_driver: Set remoteOnly member of virConnectDriver

 src/driver.h               | 2 ++
 src/esx/esx_driver.c       | 8 +-------
 src/hyperv/hyperv_driver.c | 8 +-------
 src/libvirt.c              | 5 +++++
 src/phyp/phyp_driver.c     | 7 +------
 5 files changed, 10 insertions(+), 20 deletions(-)

-- 
2.17.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/5] Making libvirt aware of a server need

Posted by Marcos Paulo de Souza 11 weeks ago
On Mon, Jul 09, 2018 at 01:22:18PM -0300, Marcos Paulo de Souza wrote:
> Hi guys,
> 
> this is basically a second version of [1], but I rewrote the patch following
> Matthias ideas [2]. It really seems a cleaner change, but, feel free to suggest
> any other change that could make the code better.
> 
> I did a lot of tests using virsh tool, so when using the ESX driver without a
> proper server, it returns a error. I could not test hyperv and phyp.
> 
> Thanks,
> 
> [1]: https://www.redhat.com/archives/libvir-list/2018-July/msg00393.html
> [2]: https://www.redhat.com/archives/libvir-list/2018-July/msg00400.html

This patchset is still not ready, I found a problem in my approach in libvirt.c.
Will resent a v3 once this is fixed.

Thanks,

> 
> Marcos Paulo de Souza (5):
>   driver.h: Add remoteOnly member to virConnectDriver struct
>   libvirt.c: Return error when remoteOnly is set but server is empty
>   esx_driver: Set remoteOnly member of virConnectDriver
>   hyperv_driver: Set remoteOnly member of virConnectDriver
>   phyp_driver: Set remoteOnly member of virConnectDriver
> 
>  src/driver.h               | 2 ++
>  src/esx/esx_driver.c       | 8 +-------
>  src/hyperv/hyperv_driver.c | 8 +-------
>  src/libvirt.c              | 5 +++++
>  src/phyp/phyp_driver.c     | 7 +------
>  5 files changed, 10 insertions(+), 20 deletions(-)
> 
> -- 
> 2.17.1
> 

-- 
Thanks,
	Marcos

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list