[libvirt] [PATCH] examples: Remove config.h from hellolibvirt and openauth

Marcos Paulo de Souza posted 1 patch 11 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20180708185653.32330-1-marcos.souza.org@gmail.com
Test syntax-check passed
examples/hellolibvirt/hellolibvirt.c | 2 --
examples/openauth/openauth.c         | 2 --
2 files changed, 4 deletions(-)

[libvirt] [PATCH] examples: Remove config.h from hellolibvirt and openauth

Posted by Marcos Paulo de Souza 11 weeks ago
These two examples do not use any definition from config.h, and by
removing it these examples can be compiled standalone.

Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
---
 When trying to remove config.h from domtop and domsuspend, a later inclusion of
 unistd.h complains about the missing config.h.

 This unistd.h come from gnulib, so I need more time to check why this header
 would complain, so for now just these examples are a good start ...

 examples/hellolibvirt/hellolibvirt.c | 2 --
 examples/openauth/openauth.c         | 2 --
 2 files changed, 4 deletions(-)

diff --git a/examples/hellolibvirt/hellolibvirt.c b/examples/hellolibvirt/hellolibvirt.c
index 02c4401987..bfb12846e6 100644
--- a/examples/hellolibvirt/hellolibvirt.c
+++ b/examples/hellolibvirt/hellolibvirt.c
@@ -2,8 +2,6 @@
  * hypervisor and gather a few bits of information about domains.
  * Similar API's exist for storage pools, networks, and interfaces. */
 
-#include <config.h>
-
 #include <stdio.h>
 #include <stdlib.h>
 #include <libvirt/libvirt.h>
diff --git a/examples/openauth/openauth.c b/examples/openauth/openauth.c
index eef46d5f52..efd21c374f 100644
--- a/examples/openauth/openauth.c
+++ b/examples/openauth/openauth.c
@@ -1,8 +1,6 @@
 /* This is a copy of the hellolibvirt example demonstaring how to use
  * virConnectOpenAuth with a custom auth callback */
 
-#include <config.h>
-
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
-- 
2.17.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] examples: Remove config.h from hellolibvirt and openauth

Posted by Erik Skultety 11 weeks ago
On Sun, Jul 08, 2018 at 03:56:53PM -0300, Marcos Paulo de Souza wrote:
> These two examples do not use any definition from config.h, and by
> removing it these examples can be compiled standalone.
>
> Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
> ---
Reviewed-by: Erik Skultety <eskultet@redhat.com>

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list