Fix regression with vhostuser and chardev FD passing

[libvirt] [PATCH 0/3] Fix regression with vhostuser and chardev FD passing

Daniel P. Berrangé posted 3 patches 5 years, 9 months ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20180705113605.15982-1-berrange@redhat.com

Test syntax-check passed

src/qemu/qemu_command.c                   | 117 ++++++++++++++--------
tests/qemuxml2argvdata/net-vhostuser.args |   3 +-
tests/qemuxml2argvtest.c                  |   2 +-
3 files changed, 75 insertions(+), 47 deletions(-)

Expand all Fold all

[libvirt] [PATCH 0/3] Fix regression with vhostuser and chardev FD passing

Posted by Daniel P. Berrangé 5 years, 9 months ago

QEMU has a validation bug which prevents vhostuser accepting the chardev
when it uses FD passing, despite it being functionally correct.

While the QEMU bug is being fixed, we need to avoid hitting this
problem with existing QEMU releases.

The easiest way todo this is to simply disable FD passing for the
chardev used with vhostuser only.

Daniel P. Berrangé (3):
  qemu: remove chardevStdioLogd param from vhostuser code path
  qemu: consolidate parameters of qemuBuildChrChardevStr into flags
  qemu: don't use chardev FD passing for vhostuser backend

 src/qemu/qemu_command.c                   | 117 ++++++++++++++--------
 tests/qemuxml2argvdata/net-vhostuser.args |   3 +-
 tests/qemuxml2argvtest.c                  |   2 +-
 3 files changed, 75 insertions(+), 47 deletions(-)

-- 
2.17.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/3] Fix regression with vhostuser and chardev FD passing

Posted by Michal Prívozník 5 years, 9 months ago

On 07/05/2018 01:36 PM, Daniel P. Berrangé wrote:
> QEMU has a validation bug which prevents vhostuser accepting the chardev
> when it uses FD passing, despite it being functionally correct.
> 
> While the QEMU bug is being fixed, we need to avoid hitting this
> problem with existing QEMU releases.
> 
> The easiest way todo this is to simply disable FD passing for the
> chardev used with vhostuser only.
> 
> Daniel P. Berrangé (3):
>   qemu: remove chardevStdioLogd param from vhostuser code path
>   qemu: consolidate parameters of qemuBuildChrChardevStr into flags
>   qemu: don't use chardev FD passing for vhostuser backend
> 
>  src/qemu/qemu_command.c                   | 117 ++++++++++++++--------
>  tests/qemuxml2argvdata/net-vhostuser.args |   3 +-
>  tests/qemuxml2argvtest.c                  |   2 +-
>  3 files changed, 75 insertions(+), 47 deletions(-)
> 


ACK series.

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list