esx_driver: Simplify IsEncrypted and IsSecure

[libvirt] [PATCH] esx_driver: Simplify IsEncrypted and IsSecure

Marcos Paulo de Souza posted 1 patch 5 years, 10 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20180626233905.5937-1-marcos.souza.org@gmail.com

Test syntax-check passed

src/esx/esx_driver.c | 12 ++----------
1 file changed, 2 insertions(+), 10 deletions(-)

Expand all Fold all

[libvirt] [PATCH] esx_driver: Simplify IsEncrypted and IsSecure

Posted by Marcos Paulo de Souza 5 years, 10 months ago

Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
---
 src/esx/esx_driver.c | 12 ++----------
 1 file changed, 2 insertions(+), 10 deletions(-)

diff --git a/src/esx/esx_driver.c b/src/esx/esx_driver.c
index 60aa5fc252..bb8eeecd42 100644
--- a/src/esx/esx_driver.c
+++ b/src/esx/esx_driver.c
@@ -4000,11 +4000,7 @@ esxConnectIsEncrypted(virConnectPtr conn)
 {
     esxPrivate *priv = conn->privateData;
 
-    if (STRCASEEQ(priv->parsedUri->transport, "https")) {
-        return 1;
-    } else {
-        return 0;
-    }
+    return STRCASEEQ(priv->parsedUri->transport, "https");
 }
 
 
@@ -4014,11 +4010,7 @@ esxConnectIsSecure(virConnectPtr conn)
 {
     esxPrivate *priv = conn->privateData;
 
-    if (STRCASEEQ(priv->parsedUri->transport, "https")) {
-        return 1;
-    } else {
-        return 0;
-    }
+    return STRCASEEQ(priv->parsedUri->transport, "https");
 }
 
 
-- 
2.17.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] esx_driver: Simplify IsEncrypted and IsSecure

Posted by Michal Prívozník 5 years, 10 months ago

On 06/27/2018 01:39 AM, Marcos Paulo de Souza wrote:
> Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
> ---
>  src/esx/esx_driver.c | 12 ++----------
>  1 file changed, 2 insertions(+), 10 deletions(-)

ACK. Will push after the freeze is over.

Congratulations on your first libvirt contribution!

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list