virstring: fix a typo

[libvirt] [PATCH] virstring: fix a typo

Chen Hanxiao posted 1 patch 5 years, 10 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20180611104621.1170-1-chen_han_xiao@126.com

Test syntax-check passed

src/util/virstring.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Expand all Fold all

[libvirt] [PATCH] virstring: fix a typo

Posted by Chen Hanxiao 5 years, 10 months ago

From: Chen Hanxiao <chenhanxiao@gmail.com>

s/glibc's_asprintf/glibc's asprintf

Signed-off-by: Chen Hanxiao <chenhanxiao@gmail.com>
---
 src/util/virstring.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/util/virstring.h b/src/util/virstring.h
index fa2ec1df4d..607ae66e99 100644
--- a/src/util/virstring.h
+++ b/src/util/virstring.h
@@ -248,7 +248,7 @@ size_t virStringListLength(const char * const *strings);
  * @strp: variable to hold result (char **)
  * @fmt: printf format
  *
- * Like glibc's_asprintf but makes sure *strp == NULL on failure, in which case
+ * Like glibc's asprintf but makes sure *strp == NULL on failure, in which case
  * the OOM error is reported too.
  *
  * Returns -1 on failure (with OOM error reported), number of bytes printed
@@ -264,7 +264,7 @@ size_t virStringListLength(const char * const *strings);
  * @strp: variable to hold result (char **)
  * @fmt: printf format
  *
- * Like glibc's_asprintf but makes sure *strp == NULL on failure.
+ * Like glibc's asprintf but makes sure *strp == NULL on failure.
  *
  * Returns -1 on failure, number of bytes printed on success.
  */
-- 
2.17.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] virstring: fix a typo

Posted by Ján Tomko 5 years, 10 months ago

On Mon, Jun 11, 2018 at 06:46:21PM +0800, Chen Hanxiao wrote:
>From: Chen Hanxiao <chenhanxiao@gmail.com>
>
>s/glibc's_asprintf/glibc's asprintf
>
>Signed-off-by: Chen Hanxiao <chenhanxiao@gmail.com>
>---
> src/util/virstring.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>

It might have been intentional to avoid syntax-check complaints,
but now that we have an exception system in place:

Reviewed-by: Ján Tomko <jtomko@redhat.com>

And pushed.

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list