Since our entire guest state is fully reproducible, keeping
backups around is not very useful; moreover, on CentOS 6 it
results in us hitting

  https://github.com/ansible/ansible/issues/31982

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 guests/tasks/bootloader.yml | 2 --
 guests/tasks/jenkins.yml    | 1 -
 guests/tasks/users.yml      | 2 --
 3 files changed, 5 deletions(-)

diff --git a/guests/tasks/bootloader.yml b/guests/tasks/bootloader.yml
index face3dd..3de8c0d 100644
--- a/guests/tasks/bootloader.yml
+++ b/guests/tasks/bootloader.yml
@@ -19,7 +19,6 @@
     path: /etc/default/grub
     regexp: '^{{ item.key }}=.*$'
     line: '{{ item.key }}="{{ item.value }}"'
-    backup: yes
   with_items:
     - { key: 'GRUB_TIMEOUT', value: '1' }
     - { key: 'GRUB_CMDLINE_LINUX_DEFAULT', value: 'console=ttyS0' }
@@ -45,7 +44,6 @@
     regexp: '^{{ item.key }}=.*$'
     line: '{{ item.key }}="{{ item.value }}"'
     create: yes
-    backup: yes
   with_items:
     - { key: 'console', value: 'comconsole' }
     - { key: 'autoboot_delay', value: '1' }
diff --git a/guests/tasks/jenkins.yml b/guests/tasks/jenkins.yml
index 10aeec7..9076c34 100644
--- a/guests/tasks/jenkins.yml
+++ b/guests/tasks/jenkins.yml
@@ -23,7 +23,6 @@
   lineinfile:
     path: /etc/rc.local
     create: yes
-    backup: yes
     regexp: '^nohup.*jenkins.*java.*slave\.jar.*&$'
     line: "nohup {{ su }} - jenkins -c '{{ java }} -jar /home/jenkins/slave.jar -jnlpUrl \"{{ jenkins_url }}\" -secret \"{{ jenkins_secret }}\"' >/var/log/jenkins.log 2>&1 &"
     insertbefore: '^exit .*$'
diff --git a/guests/tasks/users.yml b/guests/tasks/users.yml
index 033ca2a..0aa6230 100644
--- a/guests/tasks/users.yml
+++ b/guests/tasks/users.yml
@@ -17,7 +17,6 @@
     regexp: '^#*\s*PermitRootLogin\s*.*$'
     line: 'PermitRootLogin without-password'
     state: present
-    backup: yes
 
 - name: '{{ flavor }}: Create user account'
   user:
@@ -46,7 +45,6 @@
     path: '{{ sudoers }}'
     line: '{{ flavor }} ALL=(ALL) NOPASSWD: ALL'
     state: present
-    backup: yes
     validate: 'visudo -cf %s'
   when:
     - flavor == 'test'
-- 
2.17.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On Fri, May 25, 2018 at 11:16:24AM +0200, Andrea Bolognani wrote:
> Since our entire guest state is fully reproducible, keeping
> backups around is not very useful; moreover, on CentOS 6 it
> results in us hitting
> 
>   https://github.com/ansible/ansible/issues/31982
> 
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---
>  guests/tasks/bootloader.yml | 2 --
>  guests/tasks/jenkins.yml    | 1 -
>  guests/tasks/users.yml      | 2 --
>  3 files changed, 5 deletions(-)

Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list