[libvirt] [jenkins-ci PATCH] projects: Reduce scope for local_env

Andrea Bolognani posted 1 patch 5 years, 11 months ago
Failed in applying to current master (apply log)
projects/libvirt-go-xml.yaml | 4 ++--
projects/libvirt-go.yaml     | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
[libvirt] [jenkins-ci PATCH] projects: Reduce scope for local_env
Posted by Andrea Bolognani 5 years, 11 months ago
The TEST_ARGS environment variable is only used when running
the test suite, which means that local_env can be moved to the
*-check-job instead of being at the top level.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 projects/libvirt-go-xml.yaml | 4 ++--
 projects/libvirt-go.yaml     | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/projects/libvirt-go-xml.yaml b/projects/libvirt-go-xml.yaml
index 1f26751..8d9c16d 100644
--- a/projects/libvirt-go-xml.yaml
+++ b/projects/libvirt-go-xml.yaml
@@ -3,10 +3,10 @@
     name: libvirt-go-xml
     machines: '{all_machines}'
     title: Libvirt Go XML
-    local_env: |
-      export TEST_ARGS="-tags xmlroundtrip"
     jobs:
       - go-build-job:
           parent_jobs: 'libvirt-master-build'
       - go-check-job:
           parent_jobs: 'libvirt-go-xml-master-build'
+          local_env: |
+            export TEST_ARGS="-tags xmlroundtrip"
diff --git a/projects/libvirt-go.yaml b/projects/libvirt-go.yaml
index f40f523..f2eb87e 100644
--- a/projects/libvirt-go.yaml
+++ b/projects/libvirt-go.yaml
@@ -3,10 +3,10 @@
     name: libvirt-go
     machines: '{all_machines}'
     title: Libvirt Go
-    local_env: |
-      export TEST_ARGS="-tags api"
     jobs:
       - go-build-job:
           parent_jobs: 'libvirt-master-build'
       - go-check-job:
           parent_jobs: 'libvirt-go-master-build'
+          local_env: |
+            export TEST_ARGS="-tags api"
-- 
2.17.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [jenkins-ci PATCH] projects: Reduce scope for local_env
Posted by Daniel P. Berrangé 5 years, 11 months ago
On Thu, May 10, 2018 at 03:03:49PM +0200, Andrea Bolognani wrote:
> The TEST_ARGS environment variable is only used when running
> the test suite, which means that local_env can be moved to the
> *-check-job instead of being at the top level.
> 
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---
>  projects/libvirt-go-xml.yaml | 4 ++--
>  projects/libvirt-go.yaml     | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list