[libvirt] [sandbox PATCH v2 0/4] Remove Test::AutoBuild leftovers

Andrea Bolognani posted 4 patches 5 years, 11 months ago
Only 3 patches received!
autobuild.sh            | 71 -----------------------------------------
libvirt-sandbox.spec.in |  2 +-
prepare-release.sh      | 39 ++++++++++++++++++++++
3 files changed, 40 insertions(+), 72 deletions(-)
delete mode 100755 autobuild.sh
create mode 100755 prepare-release.sh
[libvirt] [sandbox PATCH v2 0/4] Remove Test::AutoBuild leftovers
Posted by Andrea Bolognani 5 years, 11 months ago
Changes from [v1]:

* rename the script instead of dropping it;

* perform some further clean ups.


[v1] https://www.redhat.com/archives/libvir-list/2018-May/msg00220.html

Andrea Bolognani (4):
  maint: Rename autobuild.sh to prepare-release.sh
  prepare-release: Drop references to MinGW builds
  prepare-release: Drop references to Test::AutoBuild
  spec: Drop %{extra_release}

 autobuild.sh            | 71 -----------------------------------------
 libvirt-sandbox.spec.in |  2 +-
 prepare-release.sh      | 39 ++++++++++++++++++++++
 3 files changed, 40 insertions(+), 72 deletions(-)
 delete mode 100755 autobuild.sh
 create mode 100755 prepare-release.sh

-- 
2.17.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [sandbox PATCH v2 0/4] Remove Test::AutoBuild leftovers
Posted by Andrea Bolognani 5 years, 11 months ago
On Mon, 2018-05-07 at 16:20 +0200, Andrea Bolognani wrote:
> Changes from [v1]:
> 
> * rename the script instead of dropping it;
> 
> * perform some further clean ups.
> 
> 
> [v1] https://www.redhat.com/archives/libvir-list/2018-May/msg00220.html
> 
> Andrea Bolognani (4):
>   maint: Rename autobuild.sh to prepare-release.sh
>   prepare-release: Drop references to MinGW builds
>   prepare-release: Drop references to Test::AutoBuild
>   spec: Drop %{extra_release}
> 
>  autobuild.sh            | 71 -----------------------------------------
>  libvirt-sandbox.spec.in |  2 +-
>  prepare-release.sh      | 39 ++++++++++++++++++++++
>  3 files changed, 40 insertions(+), 72 deletions(-)
>  delete mode 100755 autobuild.sh
>  create mode 100755 prepare-release.sh

Ping?

This is fairly trivial stuff, which I'd love to get off my queue :)

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [sandbox PATCH v2 0/4] Remove Test::AutoBuild leftovers
Posted by Erik Skultety 5 years, 11 months ago
On Tue, May 15, 2018 at 03:00:15PM +0200, Andrea Bolognani wrote:
> On Mon, 2018-05-07 at 16:20 +0200, Andrea Bolognani wrote:
> > Changes from [v1]:
> >
> > * rename the script instead of dropping it;
> >
> > * perform some further clean ups.

The changes look reasonable to me.

Reviewed-by: Erik Skultety <eskultet@redhat.com>

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [sandbox PATCH v2 0/4] Remove Test::AutoBuild leftovers
Posted by Andrea Bolognani 5 years, 11 months ago
On Wed, 2018-05-16 at 15:05 +0200, Erik Skultety wrote:
> On Tue, May 15, 2018 at 03:00:15PM +0200, Andrea Bolognani wrote:
> > On Mon, 2018-05-07 at 16:20 +0200, Andrea Bolognani wrote:
> > > Changes from [v1]:
> > > 
> > > * rename the script instead of dropping it;
> > > 
> > > * perform some further clean ups.
> 
> The changes look reasonable to me.
> 
> Reviewed-by: Erik Skultety <eskultet@redhat.com>

Pushed now, thanks :)

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
[libvirt] [sandbox PATCH v2 1/4] maint: Rename autobuild.sh to prepare-release.sh
Posted by Andrea Bolognani 5 years, 11 months ago
The script was originally used by the Test::AutoBuild
project to perform periodic automatic builds; however, that
effort has been abandoned a long time ago, and these days
libvirt-sandbox CI builds are happening on the Jenkins-based
CentOS CI environment under the libvirt umbrella[1], where
build recipes are maintained separately from the projects
themselves.

The script is still used to prepare releases, so it can't
be dropped from the repository: rename it so that its
purpose is more clearly communicated instead.

[1] https://ci.centos.org/view/libvirt/

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 autobuild.sh => prepare-release.sh | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 rename autobuild.sh => prepare-release.sh (100%)

diff --git a/autobuild.sh b/prepare-release.sh
similarity index 100%
rename from autobuild.sh
rename to prepare-release.sh
-- 
2.17.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list