[libvirt] [perl PATCH] spec: Drop %{extra_release}

Andrea Bolognani posted 1 patch 5 years, 11 months ago
Failed in applying to current master (apply log)
perl-Sys-Virt.spec.PL | 2 +-
prepare-release.sh    | 4 +---
2 files changed, 2 insertions(+), 4 deletions(-)
[libvirt] [perl PATCH] spec: Drop %{extra_release}
Posted by Andrea Bolognani 5 years, 11 months ago
It was mainly meant to be used for automatic builds through
Test::AutoBuild, so it can be removed now.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 perl-Sys-Virt.spec.PL | 2 +-
 prepare-release.sh    | 4 +---
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/perl-Sys-Virt.spec.PL b/perl-Sys-Virt.spec.PL
index dbb749d..ffa6c86 100644
--- a/perl-Sys-Virt.spec.PL
+++ b/perl-Sys-Virt.spec.PL
@@ -24,7 +24,7 @@ __DATA__
 
 Name:           perl-Sys-Virt
 Version:        @VERSION@
-Release:        1%{?dist}%{?extra_release}
+Release:        1%{?dist}
 Summary:        Represent and manage a libvirt hypervisor connection
 License:        GPLv2+ or Artistic
 Group:          Development/Libraries
diff --git a/prepare-release.sh b/prepare-release.sh
index 9de67fe..fea03f4 100755
--- a/prepare-release.sh
+++ b/prepare-release.sh
@@ -52,7 +52,5 @@ rm -f $NAME-*.tar.gz
 make dist
 
 if [ -f /usr/bin/rpmbuild ]; then
-  NOW=`date +"%s"`
-  EXTRA_RELEASE=".$USER$NOW"
-  rpmbuild --nodeps -ta --define "extra_release $EXTRA_RELEASE" --clean $NAME-*.tar.gz
+  rpmbuild --nodeps -ta --clean $NAME-*.tar.gz
 fi
-- 
2.17.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [perl PATCH] spec: Drop %{extra_release}
Posted by Daniel P. Berrangé 5 years, 11 months ago
On Fri, May 04, 2018 at 03:50:57PM +0200, Andrea Bolognani wrote:
> It was mainly meant to be used for automatic builds through
> Test::AutoBuild, so it can be removed now.
> 
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---
>  perl-Sys-Virt.spec.PL | 2 +-
>  prepare-release.sh    | 4 +---
>  2 files changed, 2 insertions(+), 4 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list