GetDomainCapabilities: input args should be NULL when passing empty string

[libvirt] [dbus PATCH] GetDomainCapabilities: input args should be NULL when passing empty string

Katerina Koukiou posted 1 patch 6 years ago

Download mbox

Failed in applying to current master (apply log)

src/connect.c | 8 ++++++++
1 file changed, 8 insertions(+)

Expand all Fold all

[libvirt] [dbus PATCH] GetDomainCapabilities: input args should be NULL when passing empty string

Posted by Katerina Koukiou 6 years ago

Signed-off-by: Katerina Koukiou <kkoukiou@redhat.com>
---
 src/connect.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/src/connect.c b/src/connect.c
index 48db724..5e577e4 100644
--- a/src/connect.c
+++ b/src/connect.c
@@ -602,6 +602,14 @@ virtDBusConnectGetDomainCapabilities(GVariant *inArgs,
 
     g_variant_get(inArgs, "(&s&s&s&su)", &emulatorbin, &arch, &machine,
                   &virttype, &flags);
+    if (g_str_equal(emulatorbin, ""))
+        emulatorbin = NULL;
+    if (g_str_equal(arch, ""))
+        arch = NULL;
+    if (g_str_equal(machine, ""))
+        machine = NULL;
+    if (g_str_equal(virttype, ""))
+        virttype = NULL;
 
     if (!virtDBusConnectOpen(connect, error))
         return;
-- 
2.15.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [dbus PATCH] GetDomainCapabilities: input args should be NULL when passing empty string

Posted by Pavel Hrdina 6 years ago

On Mon, Apr 23, 2018 at 11:25:43AM +0200, Katerina Koukiou wrote:
> Signed-off-by: Katerina Koukiou <kkoukiou@redhat.com>
> ---
>  src/connect.c | 8 ++++++++
>  1 file changed, 8 insertions(+)

Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list