[libvirt] [jenkins-ci PATCH] guests: Fix intltool-update on FreeBSD

Andrea Bolognani posted 1 patch 6 years ago
Failed in applying to current master (apply log)
guests/tasks/kludges.yml | 13 +++++++++++++
1 file changed, 13 insertions(+)
[libvirt] [jenkins-ci PATCH] guests: Fix intltool-update on FreeBSD
Posted by Andrea Bolognani 6 years ago
The tool became completely unusable after the switch to Perl
5.26; workaround the issue while we wait for a proper solution.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
Using regexes to match regexes: it's regexception.

 guests/tasks/kludges.yml | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/guests/tasks/kludges.yml b/guests/tasks/kludges.yml
index d0ff6cb..4dd06a4 100644
--- a/guests/tasks/kludges.yml
+++ b/guests/tasks/kludges.yml
@@ -46,3 +46,16 @@
   command: cap_mkdb /etc/login.conf
   when:
     - loginconf.changed
+
+# FreeBSD switched to Perl 5.26, which makes a long existing warning in
+# intltool-update turn into an error and causes jobs to fail. While we
+# wait for the port to be fixed, we can patch things up ourselves.
+#
+# See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227444
+- name: Fix intltool-update
+  replace:
+    path: /usr/local/bin/intltool-update
+    regexp: '^(.*) !~ /\\\$\{\?\$2\}\?/;$'
+    replace: '\1 !~ /\\$\\{?$2}?/;'
+  when:
+    - os_name == 'FreeBSD'
-- 
2.14.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [jenkins-ci PATCH] guests: Fix intltool-update on FreeBSD
Posted by Pavel Hrdina 6 years ago
On Wed, Apr 11, 2018 at 03:14:49PM +0200, Andrea Bolognani wrote:
> The tool became completely unusable after the switch to Perl
> 5.26; workaround the issue while we wait for a proper solution.
> 
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---
> Using regexes to match regexes: it's regexception.
> 
>  guests/tasks/kludges.yml | 13 +++++++++++++
>  1 file changed, 13 insertions(+)

Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list