virsh: add missing help info of --source to domifaddr

[libvirt] [PATCH] virsh: add missing help info of --source to domifaddr

Posted by Chen Hanxiao 7 years, 10 months ago

From: Chen Hanxiao <chenhanxiao@gmail.com>

commit b4b5c82ce forgot to add this.

Signed-off-by: Chen Hanxiao <chenhanxiao@gmail.com>
---
 tools/virsh-domain-monitor.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/virsh-domain-monitor.c b/tools/virsh-domain-monitor.c
index 68da11ed5..0f768d394 100644
--- a/tools/virsh-domain-monitor.c
+++ b/tools/virsh-domain-monitor.c
@@ -2160,7 +2160,7 @@ static const vshCmdOptDef opts_domifaddr[] = {
     {.name = "source",
      .type = VSH_OT_STRING,
      .flags = VSH_OFLAG_NONE,
-     .help = N_("address source: 'lease' or 'agent'")},
+     .help = N_("address source: 'lease', 'agent' or 'arp'")},
     {.name = NULL}
 };
 
-- 
2.14.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] virsh: add missing help info of --source to domifaddr

Posted by Chen Hanxiao 7 years, 10 months ago

At 2018-03-16 10:03:15, "Chen Hanxiao" <chen_han_xiao@126.com> wrote:
>From: Chen Hanxiao <chenhanxiao@gmail.com>
>
>commit b4b5c82ce forgot to add this.
>
>Signed-off-by: Chen Hanxiao <chenhanxiao@gmail.com>
>---
> tools/virsh-domain-monitor.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/tools/virsh-domain-monitor.c b/tools/virsh-domain-monitor.c
>index 68da11ed5..0f768d394 100644
>--- a/tools/virsh-domain-monitor.c
>+++ b/tools/virsh-domain-monitor.c
>@@ -2160,7 +2160,7 @@ static const vshCmdOptDef opts_domifaddr[] = {
>     {.name = "source",
>      .type = VSH_OT_STRING,
>      .flags = VSH_OFLAG_NONE,
>-     .help = N_("address source: 'lease' or 'agent'")},
>+     .help = N_("address source: 'lease', 'agent' or 'arp'")},
>     {.name = NULL}
> };
> 

ping

Regards,
- Chen

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] virsh: add missing help info of --source to domifaddr

Posted by John Ferlan 7 years, 10 months ago


On 03/15/2018 10:03 PM, Chen Hanxiao wrote:
> From: Chen Hanxiao <chenhanxiao@gmail.com>
> 
> commit b4b5c82ce forgot to add this.
> 
> Signed-off-by: Chen Hanxiao <chenhanxiao@gmail.com>
> ---
>  tools/virsh-domain-monitor.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/virsh-domain-monitor.c b/tools/virsh-domain-monitor.c
> index 68da11ed5..0f768d394 100644
> --- a/tools/virsh-domain-monitor.c
> +++ b/tools/virsh-domain-monitor.c
> @@ -2160,7 +2160,7 @@ static const vshCmdOptDef opts_domifaddr[] = {
>      {.name = "source",
>       .type = VSH_OT_STRING,
>       .flags = VSH_OFLAG_NONE,
> -     .help = N_("address source: 'lease' or 'agent'")},
> +     .help = N_("address source: 'lease', 'agent' or 'arp'")},

I added a comma after 'agent', e.g. 'lease', 'agent', or 'arp'

Reviewed-by: John Ferlan <jferlan@redhat.com>

(safe for freeze and pushed)

John

>      {.name = NULL}
>  };
>  
> 

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list