rpm: depend on python2, not bare python

[libvirt] [PATCH] rpm: depend on python2, not bare python

Daniel P. Berrangé posted 1 patch 6 years, 1 month ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20180315134536.12060-1-berrange@redhat.com

Test syntax-check passed

libvirt.spec.in       | 2 +-
mingw-libvirt.spec.in | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

Expand all Fold all

[libvirt] [PATCH] rpm: depend on python2, not bare python

Posted by Daniel P. Berrangé 6 years, 1 month ago

Fedora requires packages to depend on "python2" RPM, not the unversioned
"python" name. Fortunately even though RHEL-6 ships a "python" RPM, it
has a virtual Provides for the "python2" name, so we don't need to
conditionalize this.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 libvirt.spec.in       | 2 +-
 mingw-libvirt.spec.in | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/libvirt.spec.in b/libvirt.spec.in
index 8e9836ebbd..bc8257f34b 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -305,7 +305,7 @@ BuildRequires: perl-interpreter
 %else
 BuildRequires: perl
 %endif
-BuildRequires: python
+BuildRequires: python2
 %if %{with_systemd}
 BuildRequires: systemd-units
 %endif
diff --git a/mingw-libvirt.spec.in b/mingw-libvirt.spec.in
index dc18d055ba..5e12bb1cae 100644
--- a/mingw-libvirt.spec.in
+++ b/mingw-libvirt.spec.in
@@ -61,7 +61,7 @@ BuildRequires:  pkgconfig
 # Need native version for msgfmt
 BuildRequires:  gettext
 BuildRequires:  libxslt
-BuildRequires:  python
+BuildRequires:  python2
 %if 0%{?fedora} >= 27
 BuildRequires:  perl-interpreter
 %else
-- 
2.14.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] rpm: depend on python2, not bare python

Posted by Andrea Bolognani 6 years, 1 month ago

On Thu, 2018-03-15 at 13:45 +0000, Daniel P. Berrangé wrote:
> Fedora requires packages to depend on "python2" RPM, not the unversioned
> "python" name. Fortunately even though RHEL-6 ships a "python" RPM, it
> has a virtual Provides for the "python2" name, so we don't need to
> conditionalize this.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  libvirt.spec.in       | 2 +-
>  mingw-libvirt.spec.in | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Andrea Bolognani <abologna@redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list