[libvirt] [PATCH 00/10] Move the libvirtd daemon into src/remote/

Daniel P. Berrangé posted 10 patches 6 years, 2 months ago
Failed in applying to current master (apply log)
.gitignore                                         |   3 +
Makefile.am                                        |   2 +-
configure.ac                                       |   1 -
daemon/Makefile.am                                 | 465 ---------------------
daemon/THREADS.txt                                 |  52 ---
src/Makefile.am                                    | 420 ++++++++++++++++---
{daemon => src/remote}/libvirtd.aug                |   0
{daemon => src/remote}/libvirtd.conf               |   0
{daemon => src/remote}/libvirtd.init.in            |   0
{daemon => src/remote}/libvirtd.libxl.logrotate.in |   0
{daemon => src/remote}/libvirtd.logrotate.in       |   0
{daemon => src/remote}/libvirtd.lxc.logrotate.in   |   0
{daemon => src/remote}/libvirtd.pod                |   0
{daemon => src/remote}/libvirtd.policy.in          |   0
{daemon => src/remote}/libvirtd.qemu.logrotate.in  |   0
daemon/libvirt.rules => src/remote/libvirtd.rules  |   0
{daemon => src/remote}/libvirtd.sasl               |   0
{daemon => src/remote}/libvirtd.service.in         |   0
{daemon => src/remote}/libvirtd.sysconf            |   0
{daemon => src/remote}/libvirtd.sysctl             |   0
{daemon => src/remote}/libvirtd.uml.logrotate.in   |   0
{daemon => src/remote}/libvirtd.upstart            |   0
daemon/libvirtd.c => src/remote/remote_daemon.c    |  10 +-
daemon/libvirtd.h => src/remote/remote_daemon.h    |  10 +-
.../remote/remote_daemon_config.c                  |  10 +-
.../remote/remote_daemon_config.h                  |  10 +-
.../remote/remote_daemon_dispatch.c                |  16 +-
.../remote/remote_daemon_dispatch.h                |  10 +-
.../stream.c => src/remote/remote_daemon_stream.c  |   8 +-
.../stream.h => src/remote/remote_daemon_stream.h  |  12 +-
{daemon => src/remote}/test_libvirtd.aug.in        |   0
.../remote/virt-guest-shutdown.target.in           |   0
32 files changed, 410 insertions(+), 619 deletions(-)
delete mode 100644 daemon/Makefile.am
delete mode 100644 daemon/THREADS.txt
rename {daemon => src/remote}/libvirtd.aug (100%)
rename {daemon => src/remote}/libvirtd.conf (100%)
rename {daemon => src/remote}/libvirtd.init.in (100%)
rename {daemon => src/remote}/libvirtd.libxl.logrotate.in (100%)
rename {daemon => src/remote}/libvirtd.logrotate.in (100%)
rename {daemon => src/remote}/libvirtd.lxc.logrotate.in (100%)
rename {daemon => src/remote}/libvirtd.pod (100%)
rename {daemon => src/remote}/libvirtd.policy.in (100%)
rename {daemon => src/remote}/libvirtd.qemu.logrotate.in (100%)
rename daemon/libvirt.rules => src/remote/libvirtd.rules (100%)
rename {daemon => src/remote}/libvirtd.sasl (100%)
rename {daemon => src/remote}/libvirtd.service.in (100%)
rename {daemon => src/remote}/libvirtd.sysconf (100%)
rename {daemon => src/remote}/libvirtd.sysctl (100%)
rename {daemon => src/remote}/libvirtd.uml.logrotate.in (100%)
rename {daemon => src/remote}/libvirtd.upstart (100%)
rename daemon/libvirtd.c => src/remote/remote_daemon.c (99%)
rename daemon/libvirtd.h => src/remote/remote_daemon.h (93%)
rename daemon/libvirtd-config.c => src/remote/remote_daemon_config.c (98%)
rename daemon/libvirtd-config.h => src/remote/remote_daemon_config.h (92%)
rename daemon/remote.c => src/remote/remote_daemon_dispatch.c (99%)
rename daemon/remote.h => src/remote/remote_daemon_dispatch.h (85%)
rename daemon/stream.c => src/remote/remote_daemon_stream.c (99%)
rename daemon/stream.h => src/remote/remote_daemon_stream.h (85%)
rename {daemon => src/remote}/test_libvirtd.aug.in (100%)
rename daemon/virt-guest-shutdown.target => src/remote/virt-guest-shutdown.target.in (100%)
[libvirt] [PATCH 00/10] Move the libvirtd daemon into src/remote/
Posted by Daniel P. Berrangé 6 years, 2 months ago
Having a daemon/ directory makes little sense from a code structure
point of view, as 90% of the code that is built into libvirtd already
lives in the src/ directory. The virtlockd and virlogd daemons also live
entirely in src/{locking,logging} directories. This series thus moves it
all into the src/remote/ directory. This will make even more sense when
we introduce further modular daemons for various drivers.

Daniel P. Berrangé (10):
  src: simplify systemd unit file handling in make rules
  src: simplify sysv init file handling in make rules
  src: simplify sysconfig file handling in make rules
  daemon: remove obsolete doc describing daemon threading
  daemon: move libvirtd code into src/remote/ directory
  daemon: move libvirtd POD manpage into src/remote/
  daemon: move init system files into src/remote/
  daemon: move configuration files to src/remote
  daemon: move misc libvirtd policy files to src/remote/
  daemon: move logrotate files to src/remote/

 .gitignore                                         |   3 +
 Makefile.am                                        |   2 +-
 configure.ac                                       |   1 -
 daemon/Makefile.am                                 | 465 ---------------------
 daemon/THREADS.txt                                 |  52 ---
 src/Makefile.am                                    | 420 ++++++++++++++++---
 {daemon => src/remote}/libvirtd.aug                |   0
 {daemon => src/remote}/libvirtd.conf               |   0
 {daemon => src/remote}/libvirtd.init.in            |   0
 {daemon => src/remote}/libvirtd.libxl.logrotate.in |   0
 {daemon => src/remote}/libvirtd.logrotate.in       |   0
 {daemon => src/remote}/libvirtd.lxc.logrotate.in   |   0
 {daemon => src/remote}/libvirtd.pod                |   0
 {daemon => src/remote}/libvirtd.policy.in          |   0
 {daemon => src/remote}/libvirtd.qemu.logrotate.in  |   0
 daemon/libvirt.rules => src/remote/libvirtd.rules  |   0
 {daemon => src/remote}/libvirtd.sasl               |   0
 {daemon => src/remote}/libvirtd.service.in         |   0
 {daemon => src/remote}/libvirtd.sysconf            |   0
 {daemon => src/remote}/libvirtd.sysctl             |   0
 {daemon => src/remote}/libvirtd.uml.logrotate.in   |   0
 {daemon => src/remote}/libvirtd.upstart            |   0
 daemon/libvirtd.c => src/remote/remote_daemon.c    |  10 +-
 daemon/libvirtd.h => src/remote/remote_daemon.h    |  10 +-
 .../remote/remote_daemon_config.c                  |  10 +-
 .../remote/remote_daemon_config.h                  |  10 +-
 .../remote/remote_daemon_dispatch.c                |  16 +-
 .../remote/remote_daemon_dispatch.h                |  10 +-
 .../stream.c => src/remote/remote_daemon_stream.c  |   8 +-
 .../stream.h => src/remote/remote_daemon_stream.h  |  12 +-
 {daemon => src/remote}/test_libvirtd.aug.in        |   0
 .../remote/virt-guest-shutdown.target.in           |   0
 32 files changed, 410 insertions(+), 619 deletions(-)
 delete mode 100644 daemon/Makefile.am
 delete mode 100644 daemon/THREADS.txt
 rename {daemon => src/remote}/libvirtd.aug (100%)
 rename {daemon => src/remote}/libvirtd.conf (100%)
 rename {daemon => src/remote}/libvirtd.init.in (100%)
 rename {daemon => src/remote}/libvirtd.libxl.logrotate.in (100%)
 rename {daemon => src/remote}/libvirtd.logrotate.in (100%)
 rename {daemon => src/remote}/libvirtd.lxc.logrotate.in (100%)
 rename {daemon => src/remote}/libvirtd.pod (100%)
 rename {daemon => src/remote}/libvirtd.policy.in (100%)
 rename {daemon => src/remote}/libvirtd.qemu.logrotate.in (100%)
 rename daemon/libvirt.rules => src/remote/libvirtd.rules (100%)
 rename {daemon => src/remote}/libvirtd.sasl (100%)
 rename {daemon => src/remote}/libvirtd.service.in (100%)
 rename {daemon => src/remote}/libvirtd.sysconf (100%)
 rename {daemon => src/remote}/libvirtd.sysctl (100%)
 rename {daemon => src/remote}/libvirtd.uml.logrotate.in (100%)
 rename {daemon => src/remote}/libvirtd.upstart (100%)
 rename daemon/libvirtd.c => src/remote/remote_daemon.c (99%)
 rename daemon/libvirtd.h => src/remote/remote_daemon.h (93%)
 rename daemon/libvirtd-config.c => src/remote/remote_daemon_config.c (98%)
 rename daemon/libvirtd-config.h => src/remote/remote_daemon_config.h (92%)
 rename daemon/remote.c => src/remote/remote_daemon_dispatch.c (99%)
 rename daemon/remote.h => src/remote/remote_daemon_dispatch.h (85%)
 rename daemon/stream.c => src/remote/remote_daemon_stream.c (99%)
 rename daemon/stream.h => src/remote/remote_daemon_stream.h (85%)
 rename {daemon => src/remote}/test_libvirtd.aug.in (100%)
 rename daemon/virt-guest-shutdown.target => src/remote/virt-guest-shutdown.target.in (100%)

-- 
2.14.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 00/10] Move the libvirtd daemon into src/remote/
Posted by Michal Privoznik 6 years, 2 months ago
On 02/21/2018 04:35 PM, Daniel P. Berrangé wrote:
> Having a daemon/ directory makes little sense from a code structure
> point of view, as 90% of the code that is built into libvirtd already
> lives in the src/ directory. The virtlockd and virlogd daemons also live
> entirely in src/{locking,logging} directories. This series thus moves it
> all into the src/remote/ directory. This will make even more sense when
> we introduce further modular daemons for various drivers.
> 
> Daniel P. Berrangé (10):
>   src: simplify systemd unit file handling in make rules
>   src: simplify sysv init file handling in make rules
>   src: simplify sysconfig file handling in make rules
>   daemon: remove obsolete doc describing daemon threading
>   daemon: move libvirtd code into src/remote/ directory
>   daemon: move libvirtd POD manpage into src/remote/
>   daemon: move init system files into src/remote/
>   daemon: move configuration files to src/remote
>   daemon: move misc libvirtd policy files to src/remote/
>   daemon: move logrotate files to src/remote/
> 
>  .gitignore                                         |   3 +
>  Makefile.am                                        |   2 +-
>  configure.ac                                       |   1 -
>  daemon/Makefile.am                                 | 465 ---------------------
>  daemon/THREADS.txt                                 |  52 ---
>  src/Makefile.am                                    | 420 ++++++++++++++++---
>  {daemon => src/remote}/libvirtd.aug                |   0
>  {daemon => src/remote}/libvirtd.conf               |   0
>  {daemon => src/remote}/libvirtd.init.in            |   0
>  {daemon => src/remote}/libvirtd.libxl.logrotate.in |   0
>  {daemon => src/remote}/libvirtd.logrotate.in       |   0
>  {daemon => src/remote}/libvirtd.lxc.logrotate.in   |   0
>  {daemon => src/remote}/libvirtd.pod                |   0
>  {daemon => src/remote}/libvirtd.policy.in          |   0
>  {daemon => src/remote}/libvirtd.qemu.logrotate.in  |   0
>  daemon/libvirt.rules => src/remote/libvirtd.rules  |   0
>  {daemon => src/remote}/libvirtd.sasl               |   0
>  {daemon => src/remote}/libvirtd.service.in         |   0
>  {daemon => src/remote}/libvirtd.sysconf            |   0
>  {daemon => src/remote}/libvirtd.sysctl             |   0
>  {daemon => src/remote}/libvirtd.uml.logrotate.in   |   0
>  {daemon => src/remote}/libvirtd.upstart            |   0
>  daemon/libvirtd.c => src/remote/remote_daemon.c    |  10 +-
>  daemon/libvirtd.h => src/remote/remote_daemon.h    |  10 +-
>  .../remote/remote_daemon_config.c                  |  10 +-
>  .../remote/remote_daemon_config.h                  |  10 +-
>  .../remote/remote_daemon_dispatch.c                |  16 +-
>  .../remote/remote_daemon_dispatch.h                |  10 +-
>  .../stream.c => src/remote/remote_daemon_stream.c  |   8 +-
>  .../stream.h => src/remote/remote_daemon_stream.h  |  12 +-
>  {daemon => src/remote}/test_libvirtd.aug.in        |   0
>  .../remote/virt-guest-shutdown.target.in           |   0
>  32 files changed, 410 insertions(+), 619 deletions(-)
>  delete mode 100644 daemon/Makefile.am
>  delete mode 100644 daemon/THREADS.txt
>  rename {daemon => src/remote}/libvirtd.aug (100%)
>  rename {daemon => src/remote}/libvirtd.conf (100%)
>  rename {daemon => src/remote}/libvirtd.init.in (100%)
>  rename {daemon => src/remote}/libvirtd.libxl.logrotate.in (100%)
>  rename {daemon => src/remote}/libvirtd.logrotate.in (100%)
>  rename {daemon => src/remote}/libvirtd.lxc.logrotate.in (100%)
>  rename {daemon => src/remote}/libvirtd.pod (100%)
>  rename {daemon => src/remote}/libvirtd.policy.in (100%)
>  rename {daemon => src/remote}/libvirtd.qemu.logrotate.in (100%)
>  rename daemon/libvirt.rules => src/remote/libvirtd.rules (100%)
>  rename {daemon => src/remote}/libvirtd.sasl (100%)
>  rename {daemon => src/remote}/libvirtd.service.in (100%)
>  rename {daemon => src/remote}/libvirtd.sysconf (100%)
>  rename {daemon => src/remote}/libvirtd.sysctl (100%)
>  rename {daemon => src/remote}/libvirtd.uml.logrotate.in (100%)
>  rename {daemon => src/remote}/libvirtd.upstart (100%)
>  rename daemon/libvirtd.c => src/remote/remote_daemon.c (99%)
>  rename daemon/libvirtd.h => src/remote/remote_daemon.h (93%)
>  rename daemon/libvirtd-config.c => src/remote/remote_daemon_config.c (98%)
>  rename daemon/libvirtd-config.h => src/remote/remote_daemon_config.h (92%)
>  rename daemon/remote.c => src/remote/remote_daemon_dispatch.c (99%)
>  rename daemon/remote.h => src/remote/remote_daemon_dispatch.h (85%)
>  rename daemon/stream.c => src/remote/remote_daemon_stream.c (99%)
>  rename daemon/stream.h => src/remote/remote_daemon_stream.h (85%)
>  rename {daemon => src/remote}/test_libvirtd.aug.in (100%)
>  rename daemon/virt-guest-shutdown.target => src/remote/virt-guest-shutdown.target.in (100%)
> 

ACK series, but see my comments to patches before pushing.

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list