The Net::OpenSSH module requires IO::Pty if password authentication
will be used, but The Fedora Net::OpenSSH maintainers don't want to
put anything stronger that "Suggests: perl(IO::Pty)" in their
specfile, which unfortunately does absolutely nothing. (see
https://bugzilla.redhat.com/show_bug.cgi?id=1542666 ). The alternate
solution is for perl-Sys-Virt-TCK.spec to require perl(IO::Pty), and
that's what this patch does.

Signed-off-by: Laine Stump <laine@laine.org>
---
 perl-Sys-Virt-TCK.spec.PL | 1 +
 1 file changed, 1 insertion(+)

diff --git a/perl-Sys-Virt-TCK.spec.PL b/perl-Sys-Virt-TCK.spec.PL
index 1534854..7c83be9 100644
--- a/perl-Sys-Virt-TCK.spec.PL
+++ b/perl-Sys-Virt-TCK.spec.PL
@@ -74,6 +74,7 @@ Requires: perl(TAP::Formatter::HTML)
 Requires: perl(TAP::Formatter::JUnit)
 Requires: perl(TAP::Harness::Archive)
 Requires: perl(Net::OpenSSH)
+Requires: perl(IO::Pty)
 Requires: /usr/bin/mkisofs
 BuildArchitectures: noarch
 
-- 
2.14.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On Mon, Feb 19, 2018 at 06:17:31PM -0500, Laine Stump wrote:
> The Net::OpenSSH module requires IO::Pty if password authentication
> will be used, but The Fedora Net::OpenSSH maintainers don't want to
> put anything stronger that "Suggests: perl(IO::Pty)" in their
> specfile, which unfortunately does absolutely nothing. (see
> https://bugzilla.redhat.com/show_bug.cgi?id=1542666 ). The alternate
> solution is for perl-Sys-Virt-TCK.spec to require perl(IO::Pty), and
> that's what this patch does.
> 
> Signed-off-by: Laine Stump <laine@laine.org>
> ---
>  perl-Sys-Virt-TCK.spec.PL | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/perl-Sys-Virt-TCK.spec.PL b/perl-Sys-Virt-TCK.spec.PL
> index 1534854..7c83be9 100644
> --- a/perl-Sys-Virt-TCK.spec.PL
> +++ b/perl-Sys-Virt-TCK.spec.PL
> @@ -74,6 +74,7 @@ Requires: perl(TAP::Formatter::HTML)
>  Requires: perl(TAP::Formatter::JUnit)
>  Requires: perl(TAP::Harness::Archive)
>  Requires: perl(Net::OpenSSH)
> +Requires: perl(IO::Pty)
>  Requires: /usr/bin/mkisofs
>  BuildArchitectures: noarch

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list