qemu: Error out on invalid pci-root controller model name

[libvirt] [PATCH] qemu: Error out on invalid pci-root controller model name

Andrea Bolognani posted 1 patch 6 years, 2 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20180209161523.3997-1-abologna@redhat.com

src/qemu/qemu_domain.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[libvirt] [PATCH] qemu: Error out on invalid pci-root controller model name

Posted by Andrea Bolognani 6 years, 2 months ago

This is a hard error, and should be handled as such.
Introduced in 24614760228b.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 src/qemu/qemu_domain.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index 16833474a..178ec24ae 100644
--- a/src/qemu/qemu_domain.c
+++ b/src/qemu/qemu_domain.c
@@ -4446,7 +4446,7 @@ qemuDomainDeviceDefValidateControllerPCI(const virDomainControllerDef *controlle
                            _("PCI controller model name '%s' is not valid "
                              "for a pci-root"),
                            modelName);
-            return 0;
+            return -1;
         }
 
         if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_DEVICE_SPAPR_PCI_HOST_BRIDGE)) {
-- 
2.14.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] qemu: Error out on invalid pci-root controller model name

Posted by John Ferlan 6 years, 2 months ago


On 02/09/2018 11:15 AM, Andrea Bolognani wrote:
> This is a hard error, and should be handled as such.
> Introduced in 24614760228b.
> 
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---
>  src/qemu/qemu_domain.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Doh... thanks

Reviewed-by: John Ferlan <jferlan@redhat.com>

John

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list