perl: Add ERR_DEVICE_MISSING constants

[libvirt] [PATCH perl] perl: Add ERR_DEVICE_MISSING constants

Posted by Chen Hanxiao 6 years, 2 months ago

From: Chen Hanxiao <chenhanxiao@gmail.com>

Signed-off-by: Chen Hanxiao <chenhanxiao@gmail.com>
---
 Changes               | 2 +-
 Virt.xs               | 1 +
 lib/Sys/Virt/Error.pm | 4 ++++
 3 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/Changes b/Changes
index eda3ec5..22d5752 100644
--- a/Changes
+++ b/Changes
@@ -2,7 +2,7 @@ Revision history for perl module Sys::Virt
 
 4.1.0 2018-00-00
 
- - XXX
+ - Add VIR_ERR_DEVICE_MISSING constants
 
 4.0.0 2018-01-23
 
diff --git a/Virt.xs b/Virt.xs
index 7d2f1a7..f19880f 100644
--- a/Virt.xs
+++ b/Virt.xs
@@ -9488,4 +9488,5 @@ BOOT:
       REGISTER_CONSTANT(VIR_ERR_NO_CLIENT, ERR_NO_CLIENT);
       REGISTER_CONSTANT(VIR_ERR_AGENT_UNSYNCED, ERR_AGENT_UNSYNCED);
       REGISTER_CONSTANT(VIR_ERR_LIBSSH, ERR_LIBSSH);
+      REGISTER_CONSTANT(VIR_ERR_DEVICE_MISSING, ERR_DEVICE_MISSING);
     }
diff --git a/lib/Sys/Virt/Error.pm b/lib/Sys/Virt/Error.pm
index b97985d..78f33f3 100644
--- a/lib/Sys/Virt/Error.pm
+++ b/lib/Sys/Virt/Error.pm
@@ -812,6 +812,10 @@ Libvirt guest agent replies with wrong id to guest-sync command
 
 The libSSH operation failed
 
+=item Sys::Virt::Error::ERR_DEVICE_MISSING
+
+Libvirt fail to find the desired device.
+
 =back
 
 =head1 AUTHORS
-- 
2.14.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH perl] perl: Add ERR_DEVICE_MISSING constants

Posted by Daniel P. Berrangé 6 years, 2 months ago

On Thu, Feb 01, 2018 at 11:28:56AM +0800, Chen Hanxiao wrote:
> From: Chen Hanxiao <chenhanxiao@gmail.com>
> 
> Signed-off-by: Chen Hanxiao <chenhanxiao@gmail.com>
> ---
>  Changes               | 2 +-
>  Virt.xs               | 1 +
>  lib/Sys/Virt/Error.pm | 4 ++++
>  3 files changed, 6 insertions(+), 1 deletion(-)

Reviewed-by: Daniel P. Berrange <berrange@redhat.com>

> 
> diff --git a/Changes b/Changes
> index eda3ec5..22d5752 100644
> --- a/Changes
> +++ b/Changes
> @@ -2,7 +2,7 @@ Revision history for perl module Sys::Virt
>  
>  4.1.0 2018-00-00
>  
> - - XXX
> + - Add VIR_ERR_DEVICE_MISSING constants

We cna trim the trailing "s" when committing.


>  
>  4.0.0 2018-01-23
>  
> diff --git a/Virt.xs b/Virt.xs
> index 7d2f1a7..f19880f 100644
> --- a/Virt.xs
> +++ b/Virt.xs
> @@ -9488,4 +9488,5 @@ BOOT:
>        REGISTER_CONSTANT(VIR_ERR_NO_CLIENT, ERR_NO_CLIENT);
>        REGISTER_CONSTANT(VIR_ERR_AGENT_UNSYNCED, ERR_AGENT_UNSYNCED);
>        REGISTER_CONSTANT(VIR_ERR_LIBSSH, ERR_LIBSSH);
> +      REGISTER_CONSTANT(VIR_ERR_DEVICE_MISSING, ERR_DEVICE_MISSING);
>      }
> diff --git a/lib/Sys/Virt/Error.pm b/lib/Sys/Virt/Error.pm
> index b97985d..78f33f3 100644
> --- a/lib/Sys/Virt/Error.pm
> +++ b/lib/Sys/Virt/Error.pm
> @@ -812,6 +812,10 @@ Libvirt guest agent replies with wrong id to guest-sync command
>  
>  The libSSH operation failed
>  
> +=item Sys::Virt::Error::ERR_DEVICE_MISSING
> +
> +Libvirt fail to find the desired device.
> +
>  =back
>  
>  =head1 AUTHORS
> -- 
> 2.14.3
> 
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list