libxl: add explicit linkage to xenstore library

[libvirt] [PATCH] libxl: add explicit linkage to xenstore library

Posted by Daniel P. Berrange 6 years, 2 months ago

The libxl driver calls a couple of xenstorage APIs, so it must
explicitly link to this library rather than rely on indirect linkage via
libxl or other xen libraries.

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
---
 m4/virt-driver-libxl.m4 | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/m4/virt-driver-libxl.m4 b/m4/virt-driver-libxl.m4
index e6dbfef686..2cc1c062d8 100644
--- a/m4/virt-driver-libxl.m4
+++ b/m4/virt-driver-libxl.m4
@@ -75,9 +75,9 @@ AC_DEFUN([LIBVIRT_DRIVER_CHECK_LIBXL], [
     dnl (since Xen 4.7) if not then assume it is in libxenctrl
     dnl (as it was for 4.6 and earler)
     AC_CHECK_LIB([xentoollog], [xtl_createlogger_stdiostream], [
-      LIBXL_LIBS="$LIBXL_LIBS -lxentoollog"
+      LIBXL_LIBS="$LIBXL_LIBS -lxenstore -lxentoollog"
     ],[
-      LIBXL_LIBS="$LIBXL_LIBS -lxenctrl"
+      LIBXL_LIBS="$LIBXL_LIBS -lxenstore -lxenctrl"
     ])
 
     dnl Check if libxl_domain_config_from_json is available for domXML to
-- 
2.14.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] libxl: add explicit linkage to xenstore library

Posted by Jim Fehlig 6 years, 2 months ago

On 01/24/2018 03:21 AM, Daniel P. Berrange wrote:
> The libxl driver calls a couple of xenstorage APIs, so it must

s/xenstorage/xenstore/

> explicitly link to this library rather than rely on indirect linkage via
> libxl or other xen libraries.

Nod. It should have been included in commit eee7bd4e.

> 
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> ---
>   m4/virt-driver-libxl.m4 | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/m4/virt-driver-libxl.m4 b/m4/virt-driver-libxl.m4
> index e6dbfef686..2cc1c062d8 100644
> --- a/m4/virt-driver-libxl.m4
> +++ b/m4/virt-driver-libxl.m4
> @@ -75,9 +75,9 @@ AC_DEFUN([LIBVIRT_DRIVER_CHECK_LIBXL], [
>       dnl (since Xen 4.7) if not then assume it is in libxenctrl
>       dnl (as it was for 4.6 and earler)
>       AC_CHECK_LIB([xentoollog], [xtl_createlogger_stdiostream], [
> -      LIBXL_LIBS="$LIBXL_LIBS -lxentoollog"
> +      LIBXL_LIBS="$LIBXL_LIBS -lxenstore -lxentoollog"
>       ],[
> -      LIBXL_LIBS="$LIBXL_LIBS -lxenctrl"
> +      LIBXL_LIBS="$LIBXL_LIBS -lxenstore -lxenctrl"
>       ])

Reviewed-by: Jim Fehlig <jfehlig@suse.com>

Regards,
Jim

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list