[libvirt] [PATCH 0/4] Alter Disk Volume logic to use objects

John Ferlan posted 4 patches 6 years, 3 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20180109200553.22516-1-jferlan@redhat.com
src/conf/virstorageobj.c           | 540 ++++++++++++++++++++++++++++++-------
src/storage/storage_backend_disk.c |  40 +--
src/storage/storage_driver.c       |  14 +-
3 files changed, 471 insertions(+), 123 deletions(-)
[libvirt] [PATCH 0/4] Alter Disk Volume logic to use objects
Posted by John Ferlan 6 years, 3 months ago
This series converts the storage volume forward linked list into
an object that contains hash tables of volume objects.

The first two patches resolve issues seen during testing with
the Disk backend which had some special cased code to handle
the Create/Delete paths and interactions with the partition logic.
The first patch was much more quickly seen with object free logic
in place.

The second two patches make the conversion to objects and hash
tables in "smaller chunks", but they could easily be combined.

John Ferlan (4):
  storage: When delete volume avoid disk backend removal
  storage: Modify virStorageBackendDiskMakeDataVol logic
  storage: Introduce _virStorageVolObj[List]
  storage: Complete implementation volume by hash object

 src/conf/virstorageobj.c           | 540 ++++++++++++++++++++++++++++++-------
 src/storage/storage_backend_disk.c |  40 +--
 src/storage/storage_driver.c       |  14 +-
 3 files changed, 471 insertions(+), 123 deletions(-)

-- 
2.13.6

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 0/4] Alter Disk Volume logic to use objects
Posted by Michal Privoznik 6 years, 3 months ago
On 01/09/2018 09:05 PM, John Ferlan wrote:
> This series converts the storage volume forward linked list into
> an object that contains hash tables of volume objects.
> 
> The first two patches resolve issues seen during testing with
> the Disk backend which had some special cased code to handle
> the Create/Delete paths and interactions with the partition logic.
> The first patch was much more quickly seen with object free logic
> in place.
> 
> The second two patches make the conversion to objects and hash
> tables in "smaller chunks", but they could easily be combined.
> 
> John Ferlan (4):
>   storage: When delete volume avoid disk backend removal
>   storage: Modify virStorageBackendDiskMakeDataVol logic
>   storage: Introduce _virStorageVolObj[List]
>   storage: Complete implementation volume by hash object
> 
>  src/conf/virstorageobj.c           | 540 ++++++++++++++++++++++++++++++-------
>  src/storage/storage_backend_disk.c |  40 +--
>  src/storage/storage_driver.c       |  14 +-
>  3 files changed, 471 insertions(+), 123 deletions(-)
> 

ACK series, but see my points in 4/4 before pushing please.

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list