1. Patchew
  2. Libvirt
  3. View series

[libvirt] [PATCH] virerror: mark VIR_ERR_AGENT_UNSYNCED as DEPRECATED

Chen Hanxiao posted 1 patch 6 years, 4 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20171207015914.27559-1-chen_han_xiao@126.com
include/libvirt/virterror.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[libvirt] [PATCH] virerror: mark VIR_ERR_AGENT_UNSYNCED as DEPRECATED
Posted by Chen Hanxiao 6 years, 4 months ago 
From: Chen Hanxiao <chenhanxiao@gmail.com>

Since commit 5e5019bf, we've no longer use
VIR_ERR_AGENT_UNSYNCED anymore.
Mark it as DEPRECATED.

Signed-off-by: Chen Hanxiao <chenhanxiao@gmail.com>
---
 include/libvirt/virterror.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/libvirt/virterror.h b/include/libvirt/virterror.h
index d2b5f1fd4..91ba29784 100644
--- a/include/libvirt/virterror.h
+++ b/include/libvirt/virterror.h
@@ -318,7 +318,7 @@ typedef enum {
     VIR_ERR_NO_SERVER = 95,             /* Server was not found */
     VIR_ERR_NO_CLIENT = 96,             /* Client was not found */
     VIR_ERR_AGENT_UNSYNCED = 97,        /* guest agent replies with wrong id
-                                           to guest-sync command */
+                                           to guest-sync command (DEPRECATED)*/
     VIR_ERR_LIBSSH = 98,                /* error in libssh transport driver */
 } virErrorNumber;
 
-- 
2.14.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] virerror: mark VIR_ERR_AGENT_UNSYNCED as DEPRECATED
Posted by Michal Privoznik 6 years, 4 months ago 
On 12/07/2017 02:59 AM, Chen Hanxiao wrote:
> From: Chen Hanxiao <chenhanxiao@gmail.com>
> 
> Since commit 5e5019bf, we've no longer use
> VIR_ERR_AGENT_UNSYNCED anymore.
> Mark it as DEPRECATED.
> 
> Signed-off-by: Chen Hanxiao <chenhanxiao@gmail.com>
> ---
>  include/libvirt/virterror.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/libvirt/virterror.h b/include/libvirt/virterror.h
> index d2b5f1fd4..91ba29784 100644
> --- a/include/libvirt/virterror.h
> +++ b/include/libvirt/virterror.h
> @@ -318,7 +318,7 @@ typedef enum {
>      VIR_ERR_NO_SERVER = 95,             /* Server was not found */
>      VIR_ERR_NO_CLIENT = 96,             /* Client was not found */
>      VIR_ERR_AGENT_UNSYNCED = 97,        /* guest agent replies with wrong id
> -                                           to guest-sync command */
> +                                           to guest-sync command (DEPRECATED)*/
>      VIR_ERR_LIBSSH = 98,                /* error in libssh transport driver */
>  } virErrorNumber;
>  
> 

We don't really have 'deprecation' methods for libvirt.
I wish we had.

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] virerror: mark VIR_ERR_AGENT_UNSYNCED as DEPRECATED
Posted by Chen Hanxiao 6 years, 4 months ago 
At 2017-12-07 17:30:15, "Michal Privoznik" <mprivozn@redhat.com> wrote:
>On 12/07/2017 02:59 AM, Chen Hanxiao wrote:
>> From: Chen Hanxiao <chenhanxiao@gmail.com>
>> 
>> Since commit 5e5019bf, we've no longer use
>> VIR_ERR_AGENT_UNSYNCED anymore.
>> Mark it as DEPRECATED.
>> 
>> Signed-off-by: Chen Hanxiao <chenhanxiao@gmail.com>
>> ---
>>  include/libvirt/virterror.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/include/libvirt/virterror.h b/include/libvirt/virterror.h
>> index d2b5f1fd4..91ba29784 100644
>> --- a/include/libvirt/virterror.h
>> +++ b/include/libvirt/virterror.h
>> @@ -318,7 +318,7 @@ typedef enum {
>>      VIR_ERR_NO_SERVER = 95,             /* Server was not found */
>>      VIR_ERR_NO_CLIENT = 96,             /* Client was not found */
>>      VIR_ERR_AGENT_UNSYNCED = 97,        /* guest agent replies with wrong id
>> -                                           to guest-sync command */
>> +                                           to guest-sync command (DEPRECATED)*/
>>      VIR_ERR_LIBSSH = 98,                /* error in libssh transport driver */
>>  } virErrorNumber;
>>  
>> 
>
>We don't really have 'deprecation' methods for libvirt.
>I wish we had.

I just saw a similar mark at:

https://github.com/libvirt/libvirt/blob/master/include/libvirt/virterror.h#L233-L234

VIR_ERR_CALL_FAILED = 26,           /* not supported by the drivers
                                           (DEPRECATED) */


Regards,
- Chen


>
>Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] virerror: mark VIR_ERR_AGENT_UNSYNCED as DEPRECATED
Posted by Michal Privoznik 6 years, 4 months ago 
On 12/07/2017 11:29 AM, Chen Hanxiao wrote:
> 
> At 2017-12-07 17:30:15, "Michal Privoznik" <mprivozn@redhat.com> wrote:
>> On 12/07/2017 02:59 AM, Chen Hanxiao wrote:
>>> From: Chen Hanxiao <chenhanxiao@gmail.com>
>>>
>>> Since commit 5e5019bf, we've no longer use
>>> VIR_ERR_AGENT_UNSYNCED anymore.
>>> Mark it as DEPRECATED.
>>>
>>> Signed-off-by: Chen Hanxiao <chenhanxiao@gmail.com>
>>> ---
>>>  include/libvirt/virterror.h | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/include/libvirt/virterror.h b/include/libvirt/virterror.h
>>> index d2b5f1fd4..91ba29784 100644
>>> --- a/include/libvirt/virterror.h
>>> +++ b/include/libvirt/virterror.h
>>> @@ -318,7 +318,7 @@ typedef enum {
>>>      VIR_ERR_NO_SERVER = 95,             /* Server was not found */
>>>      VIR_ERR_NO_CLIENT = 96,             /* Client was not found */
>>>      VIR_ERR_AGENT_UNSYNCED = 97,        /* guest agent replies with wrong id
>>> -                                           to guest-sync command */
>>> +                                           to guest-sync command (DEPRECATED)*/
>>>      VIR_ERR_LIBSSH = 98,                /* error in libssh transport driver */
>>>  } virErrorNumber;
>>>  
>>>
>>
>> We don't really have 'deprecation' methods for libvirt.
>> I wish we had.
> 
> I just saw a similar mark at:
> 
> https://github.com/libvirt/libvirt/blob/master/include/libvirt/virterror.h#L233-L234
> 
> VIR_ERR_CALL_FAILED = 26,           /* not supported by the drivers
>                                            (DEPRECATED) */
> 
> 

Ah, very good counter example. Okay, I've added similar comment to
virErrorMsg(), ACKed and pushed.

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.