Fix environment handling

[libvirt] [jenkins-ci PATCH 0/5] Fix environment handling

Andrea Bolognani posted 5 patches 6 years, 5 months ago

Download series mbox

Failed in applying to current master (apply log)

jobs/autotools.yaml        | 17 ++++++++++++-----
jobs/defaults.yaml         |  5 +++--
jobs/generic.yaml          | 20 ++++++++++++++++----
jobs/go.yaml               |  4 ++++
jobs/perl-makemaker.yaml   |  9 ++++++---
jobs/perl-modulebuild.yaml |  6 ++++++
jobs/python-distutils.yaml |  6 ++++++
projects/libosinfo.yaml    |  2 +-
projects/libvirt.yaml      |  2 +-
projects/osinfo-db.yaml    |  4 ----
10 files changed, 55 insertions(+), 20 deletions(-)

Expand all Fold all

[libvirt] [jenkins-ci PATCH 0/5] Fix environment handling

Posted by Andrea Bolognani 6 years, 5 months ago

My own attempt at fixing libosinfo-master-rpm's failing status,
and then some.

This is an extension of Pavel's attempt[1] in a way; except of
course I think my approach is superior, otherwise I wouldn't have
bothered ;)

It also sets the groundwork for finally moving $VIRT_PREFIX and
friends out of the Jenkins server configuration, where they are
invisible to anyone but the CI admins, and into the git repository
so that they can be tracked alongside the jobs using them.


[1] https://www.redhat.com/archives/libvir-list/2017-November/msg00045.html

Andrea Bolognani (5):
  jobs: Rename {make_env} to {global_env}
  jobs: Include {global_env} everywhere
  jobs: Rename {check_env} to {env}
  jobs: Include {env} everywhere
  jobs: Include $PATH definition in {global_env}

 jobs/autotools.yaml        | 17 ++++++++++++-----
 jobs/defaults.yaml         |  5 +++--
 jobs/generic.yaml          | 20 ++++++++++++++++----
 jobs/go.yaml               |  4 ++++
 jobs/perl-makemaker.yaml   |  9 ++++++---
 jobs/perl-modulebuild.yaml |  6 ++++++
 jobs/python-distutils.yaml |  6 ++++++
 projects/libosinfo.yaml    |  2 +-
 projects/libvirt.yaml      |  2 +-
 projects/osinfo-db.yaml    |  4 ----
 10 files changed, 55 insertions(+), 20 deletions(-)

-- 
2.14.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [jenkins-ci PATCH 0/5] Fix environment handling

Posted by Pavel Hrdina 6 years, 5 months ago

On Fri, Nov 17, 2017 at 07:26:07PM +0100, Andrea Bolognani wrote:
> My own attempt at fixing libosinfo-master-rpm's failing status,
> and then some.
> 
> This is an extension of Pavel's attempt[1] in a way; except of
> course I think my approach is superior, otherwise I wouldn't have
> bothered ;)
> 
> It also sets the groundwork for finally moving $VIRT_PREFIX and
> friends out of the Jenkins server configuration, where they are
> invisible to anyone but the CI admins, and into the git repository
> so that they can be tracked alongside the jobs using them.

I've looked into the jenkins-job-builder documentation and was not able
to find a better way so we might use {global_env} for all the guest
specific environment variables.

> 
> 
> [1] https://www.redhat.com/archives/libvir-list/2017-November/msg00045.html
> 
> Andrea Bolognani (5):
>   jobs: Rename {make_env} to {global_env}
>   jobs: Include {global_env} everywhere
>   jobs: Rename {check_env} to {env}
>   jobs: Include {env} everywhere
>   jobs: Include $PATH definition in {global_env}

See my note for PATCH 3.

Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list