[libvirt] [PATCH] Revert "travis: Limit git depth to 5 commits"

Andrea Bolognani posted 1 patch 56 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20170919134919.17443-1-abologna@redhat.com
.travis.yml | 1 -
1 file changed, 1 deletion(-)

[libvirt] [PATCH] Revert "travis: Limit git depth to 5 commits"

Posted by Andrea Bolognani 56 weeks ago
Turns out a build job can be stuck waiting for a macOS worker to
become available for a pretty long time: if more than 5 commits
have been pushed in the meantime, the clone will be too shallow
for the worker to find the commit it's supposed to verify, and
the build job will fail.

See https://travis-ci.org/libvirt/libvirt/jobs/277244110 for an
example of the failure described.

This reverts commit 2e975abdc9bbc9e965486e8486cc17a771cdaeb3.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 .travis.yml | 1 -
 1 file changed, 1 deletion(-)

diff --git a/.travis.yml b/.travis.yml
index b3e73bcf7..480419dfd 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -75,7 +75,6 @@ addons:
       - zfs-fuse
 
 git:
-  depth: 5
   submodules: true
 
 env:
-- 
2.13.5

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] Revert "travis: Limit git depth to 5 commits"

Posted by Daniel P. Berrange 56 weeks ago
On Tue, Sep 19, 2017 at 03:49:19PM +0200, Andrea Bolognani wrote:
> Turns out a build job can be stuck waiting for a macOS worker to
> become available for a pretty long time: if more than 5 commits
> have been pushed in the meantime, the clone will be too shallow
> for the worker to find the commit it's supposed to verify, and
> the build job will fail.

It could even hit us more generally - travis throttles how many
parallel jobs can be run. So if two (or more) people push patch
series with more than 5 patches a few minutes apart, we might
not have finished all queued jobs.

> 
> See https://travis-ci.org/libvirt/libvirt/jobs/277244110 for an
> example of the failure described.
> 
> This reverts commit 2e975abdc9bbc9e965486e8486cc17a771cdaeb3.
> 
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---
>  .travis.yml | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/.travis.yml b/.travis.yml
> index b3e73bcf7..480419dfd 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -75,7 +75,6 @@ addons:
>        - zfs-fuse
>  
>  git:
> -  depth: 5
>    submodules: true
>  
>  env:

Reviewed-by: Daniel P. Berrange <berrange@redhat.com>

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list