[libvirt] [PATCH v2] Update to latest keycodemapdb content

Daniel P. Berrange posted 1 patch 6 years, 8 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20170809093659.16766-1-berrange@redhat.com
src/Makefile.am        | 2 +-
src/keycodemapdb       | 2 +-
src/util/virkeycode.c  | 5 ++---
tests/virkeycodetest.c | 4 ++--
4 files changed, 6 insertions(+), 7 deletions(-)
[libvirt] [PATCH v2] Update to latest keycodemapdb content
Posted by Daniel P. Berrange 6 years, 8 months ago
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
---
 src/Makefile.am        | 2 +-
 src/keycodemapdb       | 2 +-
 src/util/virkeycode.c  | 5 ++---
 tests/virkeycodetest.c | 4 ++--
 4 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/src/Makefile.am b/src/Makefile.am
index b8e875482..45b58c0ad 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -252,7 +252,7 @@ util/virkey%.7: util/virkey%.pod
 	rm -f $@-t1 && \
 	mv $@-t2 $@
 
-KEYCODES = linux osx atset1 atset2 atset3 xt xtkbd usb win32 rfb
+KEYCODES = linux osx atset1 atset2 atset3 xtkbd usb win32 rfb
 KEYNAMES = linux osx win32
 
 KEYTABLES = \
diff --git a/src/keycodemapdb b/src/keycodemapdb
index 7bf5710b2..267157b96 160000
--- a/src/keycodemapdb
+++ b/src/keycodemapdb
@@ -1 +1 @@
-Subproject commit 7bf5710b22aa8d58b7eeaaf3dc6960c26cade4f0
+Subproject commit 267157b96c62b5445de9cddd21de42fcd943ffe6
diff --git a/src/util/virkeycode.c b/src/util/virkeycode.c
index e09aaadaa..eda263218 100644
--- a/src/util/virkeycode.c
+++ b/src/util/virkeycode.c
@@ -30,7 +30,6 @@
 #include "virkeycodetable_rfb.h"
 #include "virkeycodetable_usb.h"
 #include "virkeycodetable_win32.h"
-#include "virkeycodetable_xt.h"
 #include "virkeycodetable_xtkbd.h"
 #include "virkeynametable_linux.h"
 #include "virkeynametable_osx.h"
@@ -44,7 +43,8 @@ static const char **virKeymapNames[VIR_KEYCODE_SET_LAST] = {
 
 static const unsigned short *virKeymapValues[VIR_KEYCODE_SET_LAST] = {
     [VIR_KEYCODE_SET_LINUX] = virKeyCodeTable_linux,
-    [VIR_KEYCODE_SET_XT] = virKeyCodeTable_xt,
+    /* XT is same as AT Set1 - it was included by mistake */
+    [VIR_KEYCODE_SET_XT] = virKeyCodeTable_atset1,
     [VIR_KEYCODE_SET_ATSET1] = virKeyCodeTable_atset1,
     [VIR_KEYCODE_SET_ATSET2] = virKeyCodeTable_atset2,
     [VIR_KEYCODE_SET_ATSET3] = virKeyCodeTable_atset3,
@@ -57,7 +57,6 @@ static const unsigned short *virKeymapValues[VIR_KEYCODE_SET_LAST] = {
 
 #define VIR_KEYMAP_ENTRY_MAX ARRAY_CARDINALITY(virKeyCodeTable_linux)
 
-verify(VIR_KEYMAP_ENTRY_MAX == ARRAY_CARDINALITY(virKeyCodeTable_xt));
 verify(VIR_KEYMAP_ENTRY_MAX == ARRAY_CARDINALITY(virKeyCodeTable_atset1));
 verify(VIR_KEYMAP_ENTRY_MAX == ARRAY_CARDINALITY(virKeyCodeTable_atset2));
 verify(VIR_KEYMAP_ENTRY_MAX == ARRAY_CARDINALITY(virKeyCodeTable_atset3));
diff --git a/tests/virkeycodetest.c b/tests/virkeycodetest.c
index d754385be..4092aa119 100644
--- a/tests/virkeycodetest.c
+++ b/tests/virkeycodetest.c
@@ -56,9 +56,9 @@ static int testKeycodeMapping(const void *data ATTRIBUTE_UNUSED)
     TRANSLATE(LINUX, USB, 111, 76);
     TRANSLATE(LINUX, RFB, 88, 88);
     TRANSLATE(LINUX, RFB, 160, 163);
-    TRANSLATE(ATSET2, ATSET3, 259, 55);
+    TRANSLATE(ATSET2, ATSET3, 131, 55);
     TRANSLATE(OSX, WIN32, 90, 131);
-    TRANSLATE(OSX, ATSET1, 90, 0);
+    TRANSLATE(OSX, ATSET1, 90, 90);
     TRANSLATE(OSX, ATSET1, 3200, -1);
 
 #undef TRANSLATE
-- 
2.13.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v2] Update to latest keycodemapdb content
Posted by Andrea Bolognani 6 years, 8 months ago
On Wed, 2017-08-09 at 10:36 +0100, Daniel P. Berrange wrote:
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> ---
>  src/Makefile.am        | 2 +-
>  src/keycodemapdb       | 2 +-
>  src/util/virkeycode.c  | 5 ++---
>  tests/virkeycodetest.c | 4 ++--
>  4 files changed, 6 insertions(+), 7 deletions(-)

Reviewed-by: Andrea Bolognani <abologna@redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list