[v1] Refactor into smaller components

[libvirt] [libvirt-php PATCH 00/13] Refactor into smaller components

Dawid Zamirski posted 13 patches 6 years, 8 months ago

Diff against v2
Download series mbox

Failed in applying to current master (apply log)

There is a newer version of this series

AUTHORS                  |   29 +-
src/Makefile.am          |   11 +-
src/libvirt-connection.c |  885 +++++
src/libvirt-connection.h |   83 +
src/libvirt-domain.c     | 3339 +++++++++++++++++
src/libvirt-domain.h     |  208 ++
src/libvirt-network.c    |  586 +++
src/libvirt-network.h    |   73 +
src/libvirt-node.c       |  304 ++
src/libvirt-node.h       |   25 +
src/libvirt-nodedev.c    |  339 ++
src/libvirt-nodedev.h    |   54 +
src/libvirt-nwfilter.c   |  414 +++
src/libvirt-nwfilter.h   |   66 +
src/libvirt-php.c        | 9282 ++++------------------------------------------
src/libvirt-php.h        |  492 +--
src/libvirt-snapshot.c   |  243 ++
src/libvirt-snapshot.h   |   58 +
src/libvirt-storage.c    | 1129 ++++++
src/libvirt-storage.h    |  138 +
src/libvirt-stream.c     |  229 ++
src/libvirt-stream.h     |   39 +
src/sockets.c            |   47 +-
src/sockets.h            |    4 -
src/util.c               |    3 -
src/util.h               |  189 +-
src/vncfunc.c            |  141 +-
src/vncfunc.h            |    4 -
28 files changed, 9366 insertions(+), 9048 deletions(-)
create mode 100644 src/libvirt-connection.c
create mode 100644 src/libvirt-connection.h
create mode 100644 src/libvirt-domain.c
create mode 100644 src/libvirt-domain.h
create mode 100644 src/libvirt-network.c
create mode 100644 src/libvirt-network.h
create mode 100644 src/libvirt-node.c
create mode 100644 src/libvirt-node.h
create mode 100644 src/libvirt-nodedev.c
create mode 100644 src/libvirt-nodedev.h
create mode 100644 src/libvirt-nwfilter.c
create mode 100644 src/libvirt-nwfilter.h
create mode 100644 src/libvirt-snapshot.c
create mode 100644 src/libvirt-snapshot.h
create mode 100644 src/libvirt-storage.c
create mode 100644 src/libvirt-storage.h
create mode 100644 src/libvirt-stream.c
create mode 100644 src/libvirt-stream.h

Expand all Fold all

[libvirt] [libvirt-php PATCH 00/13] Refactor into smaller components

Posted by Dawid Zamirski 6 years, 8 months ago

As per [1], this patch series splits up the large libvirt-php.c into
components that (attempts) to resemble the structure of the libvirt
project. Each patch successive patch was compile-tested while the whole
series was verified with "make check" and a simple custom written PHP
script.

Dawid Zamirski (13):
  Move PHP version compat macros to utils.h
  Update AUTHORS file
  Do not reuse PHPFUNC macro definition
  Split up the bindings for libvirt connection API
  Split up the bindings for libvirt node API
  Split up the bindings for libvirt stream API
  Split up the bindings for libvirt domain API
  Split up the bindings for libvirt network API
  Split up the bindings for libvirt storage API
  Split up the bindings for libvirt snapshot API
  Split up the bindings for libvirt nodedev API
  Split up the bindings for libvirt NWFilter API
  Fix is_local_connection implementation.

 AUTHORS                  |   29 +-
 src/Makefile.am          |   11 +-
 src/libvirt-connection.c |  885 +++++
 src/libvirt-connection.h |   83 +
 src/libvirt-domain.c     | 3339 +++++++++++++++++
 src/libvirt-domain.h     |  208 ++
 src/libvirt-network.c    |  586 +++
 src/libvirt-network.h    |   73 +
 src/libvirt-node.c       |  304 ++
 src/libvirt-node.h       |   25 +
 src/libvirt-nodedev.c    |  339 ++
 src/libvirt-nodedev.h    |   54 +
 src/libvirt-nwfilter.c   |  414 +++
 src/libvirt-nwfilter.h   |   66 +
 src/libvirt-php.c        | 9282 ++++------------------------------------------
 src/libvirt-php.h        |  492 +--
 src/libvirt-snapshot.c   |  243 ++
 src/libvirt-snapshot.h   |   58 +
 src/libvirt-storage.c    | 1129 ++++++
 src/libvirt-storage.h    |  138 +
 src/libvirt-stream.c     |  229 ++
 src/libvirt-stream.h     |   39 +
 src/sockets.c            |   47 +-
 src/sockets.h            |    4 -
 src/util.c               |    3 -
 src/util.h               |  189 +-
 src/vncfunc.c            |  141 +-
 src/vncfunc.h            |    4 -
 28 files changed, 9366 insertions(+), 9048 deletions(-)
 create mode 100644 src/libvirt-connection.c
 create mode 100644 src/libvirt-connection.h
 create mode 100644 src/libvirt-domain.c
 create mode 100644 src/libvirt-domain.h
 create mode 100644 src/libvirt-network.c
 create mode 100644 src/libvirt-network.h
 create mode 100644 src/libvirt-node.c
 create mode 100644 src/libvirt-node.h
 create mode 100644 src/libvirt-nodedev.c
 create mode 100644 src/libvirt-nodedev.h
 create mode 100644 src/libvirt-nwfilter.c
 create mode 100644 src/libvirt-nwfilter.h
 create mode 100644 src/libvirt-snapshot.c
 create mode 100644 src/libvirt-snapshot.h
 create mode 100644 src/libvirt-storage.c
 create mode 100644 src/libvirt-storage.h
 create mode 100644 src/libvirt-stream.c
 create mode 100644 src/libvirt-stream.h

-- 
2.13.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [libvirt-php PATCH 00/13] Refactor into smaller components

Posted by Dawid Zamirski 6 years, 8 months ago

On Tue, 2017-08-01 at 17:46 -0400, Dawid Zamirski wrote:
> As per [1], this patch series splits up the large libvirt-php.c into
> components that (attempts) to resemble the structure of the libvirt
> project. Each patch successive patch was compile-tested while the
> whole
> series was verified with "make check" and a simple custom written PHP
> script.

Missed the link for [1] in cover letter:

[1] https://www.redhat.com/archives/libvir-list/2017-June/msg00991.html


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list