[libvirt] [PATCH] tests: enable qemu 2.9 capabilities test for s390

Boris Fiuczynski posted 1 patch 115 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20170706150823.8116-1-fiuczy@linux.vnet.ibm.com
tests/qemucapabilitiesdata/caps_2.9.50.s390x.xml | 8 +++++---
tests/qemucapabilitiestest.c                     | 1 +
2 files changed, 6 insertions(+), 3 deletions(-)

[libvirt] [PATCH] tests: enable qemu 2.9 capabilities test for s390

Posted by Boris Fiuczynski 115 weeks ago
Adjust qemu 2.9 s390 capabilites xml and enable qemu capabilities test.

Signed-off-by: Boris Fiuczynski <fiuczy@linux.vnet.ibm.com>
Reviewed-by: Marc Hartmayer <mhartmay@linux.vnet.ibm.com>
---
 tests/qemucapabilitiesdata/caps_2.9.50.s390x.xml | 8 +++++---
 tests/qemucapabilitiestest.c                     | 1 +
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/tests/qemucapabilitiesdata/caps_2.9.50.s390x.xml b/tests/qemucapabilitiesdata/caps_2.9.50.s390x.xml
index 7d46128..fa9d91d 100644
--- a/tests/qemucapabilitiesdata/caps_2.9.50.s390x.xml
+++ b/tests/qemucapabilitiesdata/caps_2.9.50.s390x.xml
@@ -1,7 +1,7 @@
 <qemuCaps>
-  <qemuctime>1495812539</qemuctime>
-  <selfctime>1496170776</selfctime>
-  <selfvers>3004000</selfvers>
+  <qemuctime>0</qemuctime>
+  <selfctime>0</selfctime>
+  <selfvers>0</selfvers>
   <usedQMP/>
   <flag name='kvm'/>
   <flag name='mem-path'/>
@@ -133,6 +133,8 @@
   <flag name='query-named-block-nodes'/>
   <flag name='kernel-irqchip'/>
   <flag name='kernel-irqchip.split'/>
+  <flag name='virtio.iommu_platform'/>
+  <flag name='virtio.ats'/>
   <flag name='loadparm'/>
   <version>2009050</version>
   <kvmVersion>0</kvmVersion>
diff --git a/tests/qemucapabilitiestest.c b/tests/qemucapabilitiestest.c
index bbb683e..c76da05 100644
--- a/tests/qemucapabilitiestest.c
+++ b/tests/qemucapabilitiestest.c
@@ -175,6 +175,7 @@ mymain(void)
     DO_TEST("ppc64le", "caps_2.6.0");
     DO_TEST("s390x", "caps_2.7.0");
     DO_TEST("s390x", "caps_2.8.0");
+    DO_TEST("s390x", "caps_2.9.50");
 
     /*
      * Run "tests/qemucapsprobe /path/to/qemu/binary >foo.replies"
-- 
2.7.4

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] tests: enable qemu 2.9 capabilities test for s390

Posted by Ján Tomko 115 weeks ago
On Thu, Jul 06, 2017 at 05:08:23PM +0200, Boris Fiuczynski wrote:
>Adjust qemu 2.9 s390 capabilites xml and enable qemu capabilities test.
>
>Signed-off-by: Boris Fiuczynski <fiuczy@linux.vnet.ibm.com>
>Reviewed-by: Marc Hartmayer <mhartmay@linux.vnet.ibm.com>
>---
> tests/qemucapabilitiesdata/caps_2.9.50.s390x.xml | 8 +++++---
> tests/qemucapabilitiestest.c                     | 1 +
> 2 files changed, 6 insertions(+), 3 deletions(-)
>
>diff --git a/tests/qemucapabilitiesdata/caps_2.9.50.s390x.xml b/tests/qemucapabilitiesdata/caps_2.9.50.s390x.xml
>index 7d46128..fa9d91d 100644
>--- a/tests/qemucapabilitiesdata/caps_2.9.50.s390x.xml
>+++ b/tests/qemucapabilitiesdata/caps_2.9.50.s390x.xml

Now that QEMU 2.9 is already out, could you please update the file to
match the 2.9 release and rename the test file?

We don't need to keep capabilities of unreleased QEMUs in the git.

Jan
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list