use proper arginfo for libvirt_domain_create

[libvirt] [libvirt-php PATCH] use proper arginfo for libvirt_domain_create

Posted by Dawid Zamirski 8 years, 8 months ago

this function takes only resource argument.
---
 src/libvirt-php.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/libvirt-php.c b/src/libvirt-php.c
index bfc9b7d..99d6397 100644
--- a/src/libvirt-php.c
+++ b/src/libvirt-php.c
@@ -629,7 +629,7 @@ static zend_function_entry libvirt_functions[] = {
     PHP_FE(libvirt_domain_lookup_by_uuid,        arginfo_libvirt_conn_uuid)
     PHP_FE(libvirt_domain_lookup_by_uuid_string, arginfo_libvirt_conn_uuid)
     PHP_FE(libvirt_domain_destroy,               arginfo_libvirt_conn)
-    PHP_FE(libvirt_domain_create,                arginfo_libvirt_conn_xml)
+    PHP_FE(libvirt_domain_create,                arginfo_libvirt_conn)
     PHP_FE(libvirt_domain_resume,                arginfo_libvirt_conn)
     PHP_FE(libvirt_domain_core_dump,             arginfo_libvirt_domain_core_dump)
     PHP_FE(libvirt_domain_shutdown,              arginfo_libvirt_conn)
-- 
2.13.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [libvirt-php PATCH] use proper arginfo for libvirt_domain_create

Posted by Michal Privoznik 8 years, 8 months ago

On 05/26/2017 04:32 PM, Dawid Zamirski wrote:
> this function takes only resource argument.
> ---
>  src/libvirt-php.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/libvirt-php.c b/src/libvirt-php.c
> index bfc9b7d..99d6397 100644
> --- a/src/libvirt-php.c
> +++ b/src/libvirt-php.c
> @@ -629,7 +629,7 @@ static zend_function_entry libvirt_functions[] = {
>      PHP_FE(libvirt_domain_lookup_by_uuid,        arginfo_libvirt_conn_uuid)
>      PHP_FE(libvirt_domain_lookup_by_uuid_string, arginfo_libvirt_conn_uuid)
>      PHP_FE(libvirt_domain_destroy,               arginfo_libvirt_conn)
> -    PHP_FE(libvirt_domain_create,                arginfo_libvirt_conn_xml)
> +    PHP_FE(libvirt_domain_create,                arginfo_libvirt_conn)
>      PHP_FE(libvirt_domain_resume,                arginfo_libvirt_conn)
>      PHP_FE(libvirt_domain_core_dump,             arginfo_libvirt_domain_core_dump)
>      PHP_FE(libvirt_domain_shutdown,              arginfo_libvirt_conn)
> 

ACKed and pushed. Thanks.

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list