1. Patchew
  2. Libvirt
  3. View series

[libvirt] [PATCH 0/8] Multiple cleanups within interfaceobj and interface driver

John Ferlan posted 8 patches 6 years, 11 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20170425223656.20740-1-jferlan@redhat.com
There is a newer version of this series
src/conf/virinterfaceobj.c | 232 +++++++++++++++++++++++++++++----------------
src/conf/virinterfaceobj.h |  65 ++++++-------
src/libvirt_private.syms   |  15 +--
src/test/test_driver.c     | 143 ++++++++++++++--------------
4 files changed, 262 insertions(+), 193 deletions(-)
[libvirt] [PATCH 0/8] Multiple cleanups within interfaceobj and interface driver
Posted by John Ferlan 6 years, 11 months ago 
Sensing a theme lately yet?

More adjustments in preparation for having virobject code handle the bulk
of the object management code.

Far less in this series than the other two... The Clone code was a bit
unique and required more of a rewrite than a refigure since now we have
two allocated lists rather than two static lists.

John Ferlan (8):
  interface: Consistently use 'obj' for a virInterfaceObjPtr
  interface: Remove some unnecessary goto's for Interface tests
  interface: Use virInterfaceDefPtr rather than deref from
    virInterfaceObjPtr
  interface: Make _virInterfaceObj struct private
  interface: Make _virInterfaceObjList struct private
  interface: Rename some virInterfaceObj* API's
  interface: Clean up virInterfaceObjListFindByMACString
  interface: Introduce virInterfaceObjNew

 src/conf/virinterfaceobj.c | 232 +++++++++++++++++++++++++++++----------------
 src/conf/virinterfaceobj.h |  65 ++++++-------
 src/libvirt_private.syms   |  15 +--
 src/test/test_driver.c     | 143 ++++++++++++++--------------
 4 files changed, 262 insertions(+), 193 deletions(-)

-- 
2.9.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 0/8] Multiple cleanups within interfaceobj and interface driver
Posted by John Ferlan 6 years, 11 months ago 
ping?

NB: In the virInterfaceObjList patch, I've added a
VIR_FREE(interfaces->objs); to virInterfaceObjListFree. It should be
obvious why...

Tks -

John

On 04/25/2017 06:36 PM, John Ferlan wrote:
> Sensing a theme lately yet?
> 
> More adjustments in preparation for having virobject code handle the bulk
> of the object management code.
> 
> Far less in this series than the other two... The Clone code was a bit
> unique and required more of a rewrite than a refigure since now we have
> two allocated lists rather than two static lists.
> 
> John Ferlan (8):
>   interface: Consistently use 'obj' for a virInterfaceObjPtr
>   interface: Remove some unnecessary goto's for Interface tests
>   interface: Use virInterfaceDefPtr rather than deref from
>     virInterfaceObjPtr
>   interface: Make _virInterfaceObj struct private
>   interface: Make _virInterfaceObjList struct private
>   interface: Rename some virInterfaceObj* API's
>   interface: Clean up virInterfaceObjListFindByMACString
>   interface: Introduce virInterfaceObjNew
> 
>  src/conf/virinterfaceobj.c | 232 +++++++++++++++++++++++++++++----------------
>  src/conf/virinterfaceobj.h |  65 ++++++-------
>  src/libvirt_private.syms   |  15 +--
>  src/test/test_driver.c     | 143 ++++++++++++++--------------
>  4 files changed, 262 insertions(+), 193 deletions(-)
> 

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 0/8] Multiple cleanups within interfaceobj and interface driver
Posted by John Ferlan 6 years, 11 months ago 
ping^2?

Tks -

John

On 05/09/2017 12:13 PM, John Ferlan wrote:
> 
> ping?
> 
> NB: In the virInterfaceObjList patch, I've added a
> VIR_FREE(interfaces->objs); to virInterfaceObjListFree. It should be
> obvious why...
> 
> Tks -
> 
> John
> 
> On 04/25/2017 06:36 PM, John Ferlan wrote:
>> Sensing a theme lately yet?
>>
>> More adjustments in preparation for having virobject code handle the bulk
>> of the object management code.
>>
>> Far less in this series than the other two... The Clone code was a bit
>> unique and required more of a rewrite than a refigure since now we have
>> two allocated lists rather than two static lists.
>>
>> John Ferlan (8):
>>   interface: Consistently use 'obj' for a virInterfaceObjPtr
>>   interface: Remove some unnecessary goto's for Interface tests
>>   interface: Use virInterfaceDefPtr rather than deref from
>>     virInterfaceObjPtr
>>   interface: Make _virInterfaceObj struct private
>>   interface: Make _virInterfaceObjList struct private
>>   interface: Rename some virInterfaceObj* API's
>>   interface: Clean up virInterfaceObjListFindByMACString
>>   interface: Introduce virInterfaceObjNew
>>
>>  src/conf/virinterfaceobj.c | 232 +++++++++++++++++++++++++++++----------------
>>  src/conf/virinterfaceobj.h |  65 ++++++-------
>>  src/libvirt_private.syms   |  15 +--
>>  src/test/test_driver.c     | 143 ++++++++++++++--------------
>>  4 files changed, 262 insertions(+), 193 deletions(-)
>>
> 
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
> 

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 0/8] Multiple cleanups within interfaceobj and interface driver
Posted by Michal Privoznik 6 years, 11 months ago 
On 04/26/2017 12:36 AM, John Ferlan wrote:
> Sensing a theme lately yet?
> 
> More adjustments in preparation for having virobject code handle the bulk
> of the object management code.
> 
> Far less in this series than the other two... The Clone code was a bit
> unique and required more of a rewrite than a refigure since now we have
> two allocated lists rather than two static lists.
> 
> John Ferlan (8):
>   interface: Consistently use 'obj' for a virInterfaceObjPtr
>   interface: Remove some unnecessary goto's for Interface tests
>   interface: Use virInterfaceDefPtr rather than deref from
>     virInterfaceObjPtr
>   interface: Make _virInterfaceObj struct private
>   interface: Make _virInterfaceObjList struct private
>   interface: Rename some virInterfaceObj* API's
>   interface: Clean up virInterfaceObjListFindByMACString
>   interface: Introduce virInterfaceObjNew
> 
>  src/conf/virinterfaceobj.c | 232 +++++++++++++++++++++++++++++----------------
>  src/conf/virinterfaceobj.h |  65 ++++++-------
>  src/libvirt_private.syms   |  15 +--
>  src/test/test_driver.c     | 143 ++++++++++++++--------------
>  4 files changed, 262 insertions(+), 193 deletions(-)
> 

I'm tempted to ACK this, however, patch 8/8 stopped me. I think that if
we are doing this, we can finally turn virInterfaceObj into virObject.

ACK to the rest though.

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.