[libvirt] [PATCH v3 0/2] Use the shared keycodemap database

Daniel P. Berrange posted 2 patches 6 years, 11 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20170425135108.24954-1-berrange@redhat.com
.gitignore                    |   3 +-
.gitmodules                   |   3 +
libvirt.spec.in               |   1 +
mingw-libvirt.spec.in         |   2 +
src/Makefile.am               |  86 ++++++--
src/keycodemapdb              |   1 +
src/util/keymaps.csv          | 464 ------------------------------------------
src/util/virkeycode-mapgen.py |  97 ---------
src/util/virkeycode.c         |  94 ++++-----
tests/virkeycodetest.c        |   5 +
tools/virsh.pod               |  20 ++
11 files changed, 153 insertions(+), 623 deletions(-)
create mode 160000 src/keycodemapdb
delete mode 100644 src/util/keymaps.csv
delete mode 100755 src/util/virkeycode-mapgen.py
[libvirt] [PATCH v3 0/2] Use the shared keycodemap database
Posted by Daniel P. Berrange 6 years, 11 months ago
Follow up to:

  v1: https://www.redhat.com/archives/libvir-list/2017-March/msg00070.html
  v2: https://www.redhat.com/archives/libvir-list/2017-March/msg00136.html

Changed in v3:

  - Rebase onto new autogen.sh
  - Use VIR_KEYMAP_ENTRY_MAX constant more
  - Change style of make vars
  - Fix & verify distcheck

Changed in v2:

  - Fixed make syntax-check errors
  - Auto-generate man pages listing value key codes for use with
    the virDomainSendKey API / virsh send-key command

Daniel P. Berrange (2):
  util: switch over to use keycodemapdb GIT submodule
  Add ability to generate man page describing key code names & values

 .gitignore                    |   3 +-
 .gitmodules                   |   3 +
 libvirt.spec.in               |   1 +
 mingw-libvirt.spec.in         |   2 +
 src/Makefile.am               |  86 ++++++--
 src/keycodemapdb              |   1 +
 src/util/keymaps.csv          | 464 ------------------------------------------
 src/util/virkeycode-mapgen.py |  97 ---------
 src/util/virkeycode.c         |  94 ++++-----
 tests/virkeycodetest.c        |   5 +
 tools/virsh.pod               |  20 ++
 11 files changed, 153 insertions(+), 623 deletions(-)
 create mode 160000 src/keycodemapdb
 delete mode 100644 src/util/keymaps.csv
 delete mode 100755 src/util/virkeycode-mapgen.py

-- 
2.9.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v3 0/2] Use the shared keycodemap database
Posted by Andrea Bolognani 6 years, 11 months ago
On Tue, 2017-04-25 at 14:51 +0100, Daniel P. Berrange wrote:
> Follow up to:
> 
>   v1: https://www.redhat.com/archives/libvir-list/2017-March/msg00070.html
>   v2: https://www.redhat.com/archives/libvir-list/2017-March/msg00136.html
> 
> Changed in v3:
> 
>   - Rebase onto new autogen.sh
>   - Use VIR_KEYMAP_ENTRY_MAX constant more
>   - Change style of make vars
>   - Fix & verify distcheck
> 
> Changed in v2:
> 
>   - Fixed make syntax-check errors
>   - Auto-generate man pages listing value key codes for use with
>     the virDomainSendKey API / virsh send-key command
> 
> Daniel P. Berrange (2):
>   util: switch over to use keycodemapdb GIT submodule
>   Add ability to generate man page describing key code names & values
> 
>  .gitignore                    |   3 +-
>  .gitmodules                   |   3 +
>  libvirt.spec.in               |   1 +
>  mingw-libvirt.spec.in         |   2 +
>  src/Makefile.am               |  86 ++++++--
>  src/keycodemapdb              |   1 +
>  src/util/keymaps.csv          | 464 ------------------------------------------
>  src/util/virkeycode-mapgen.py |  97 ---------
>  src/util/virkeycode.c         |  94 ++++-----
>  tests/virkeycodetest.c        |   5 +
>  tools/virsh.pod               |  20 ++
>  11 files changed, 153 insertions(+), 623 deletions(-)
>  create mode 160000 src/keycodemapdb
>  delete mode 100644 src/util/keymaps.csv
>  delete mode 100755 src/util/virkeycode-mapgen.py

ACK series after you address the small nit I pointed out in
patch 1/2.

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list