[v1] Multiple cleanups within nwfilterobj and nwfilter drivers

[libvirt] [PATCH 03/15] nwfilter: Remove unused 'active' in virNWFilterObj

Posted by John Ferlan 8 years, 9 months ago

It was only ever set to false, which is ironically the default

Signed-off-by: John Ferlan <jferlan@redhat.com>
---
 src/conf/virnwfilterobj.c | 1 -
 src/conf/virnwfilterobj.h | 1 -
 2 files changed, 2 deletions(-)

diff --git a/src/conf/virnwfilterobj.c b/src/conf/virnwfilterobj.c
index 3c6bdbb..9e7d584 100644
--- a/src/conf/virnwfilterobj.c
+++ b/src/conf/virnwfilterobj.c
@@ -308,7 +308,6 @@ virNWFilterObjAssignDef(virNWFilterObjListPtr nwfilters,
         return NULL;
     }
     virNWFilterObjLock(obj);
-    obj->active = 0;
 
     if (VIR_APPEND_ELEMENT_COPY(nwfilters->objs,
                                 nwfilters->count, obj) < 0) {
diff --git a/src/conf/virnwfilterobj.h b/src/conf/virnwfilterobj.h
index 2adffd9..7a2addf 100644
--- a/src/conf/virnwfilterobj.h
+++ b/src/conf/virnwfilterobj.h
@@ -29,7 +29,6 @@ typedef virNWFilterObj *virNWFilterObjPtr;
 struct _virNWFilterObj {
     virMutex lock;
 
-    int active;
     int wantRemoved;
 
     virNWFilterDefPtr def;
-- 
2.9.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 03/15] nwfilter: Remove unused 'active' in virNWFilterObj

Posted by Pavel Hrdina 8 years, 9 months ago

On Mon, Apr 24, 2017 at 03:18:32PM -0400, John Ferlan wrote:
> It was only ever set to false, which is ironically the default
> 
> Signed-off-by: John Ferlan <jferlan@redhat.com>
> ---
>  src/conf/virnwfilterobj.c | 1 -
>  src/conf/virnwfilterobj.h | 1 -
>  2 files changed, 2 deletions(-)

ACK

Pavel
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list